Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4813666yba; Tue, 30 Apr 2019 04:57:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3oge4cj0JujklXv63xp2hHig+aFJViHmx/q39/bRebTmKyJyjlbn216WdZIXYl8DK7h4r X-Received: by 2002:a65:4183:: with SMTP id a3mr65702732pgq.121.1556625460083; Tue, 30 Apr 2019 04:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556625460; cv=none; d=google.com; s=arc-20160816; b=aAIkDuYEUw5wOB/YhpqQcRpeWBopFjImMna+VVxojSe162dV6i2mshNmFLbblfpdKN AdkY9jep8Ish3vz/CrCV9Wdtz5jnMdF7kn7eaVwoktZGBRT9AV3DYh3irIgSRD2tzaPz 3Na9RukWv2Ip09hp7Z1VrqBnhlcEJBH5QcUGXXZYpHPzjaYpkiaP5Jho6rkY9pYGhIDn XRHxqtTrURgfQm7ZmhJzUg5JK6RAXNdo0NzEHm34B8X8q/mm+B9TLdkrgPlboaqG8DM8 ch/VtG5LNs2JLou1VEgcsDLO8232I0qHyFwmNQDaRryQcxCWQJsYugvEZphA0K83KrGv qCtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OabryKJvcBE87PK5kIwK+kpbvX3oOY9uvgPmkEYw9zw=; b=KvP/3L7DeebtBatr0rZ3J6OwGqHr66RjE8UB6g73X4tVZ6FfCtf6899b8h5I9xQum3 98fh/b3YrHyJL3p+AJ3p8jFEkWmG4MHLyp7IF9nAxw+15phbtC5e5uo7WAXPISBnIEok 4tPtpGJU+Bhpwe5t4EaliEJKvzwc3f2Pktiag6An1SA3177QpgUnBeHC3iQv8vVqz87P HYhIAN4ND03WPM7flh5MOcA9cim7pqC2JNOOuAAeDio+R4J85G/lb/+/uKb3Og5sYb7H H0PEn3MdVtwCvXxn9ArlTcst/9ATR/vg9URmRAgF6iRSkiOLXMAT1ABbdXP+91f43J+/ vbYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fRtuQDYn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x4si36507717plv.329.2019.04.30.04.57.24; Tue, 30 Apr 2019 04:57:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fRtuQDYn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728361AbfD3Lzt (ORCPT + 99 others); Tue, 30 Apr 2019 07:55:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:35740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730668AbfD3LtP (ORCPT ); Tue, 30 Apr 2019 07:49:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7844421707; Tue, 30 Apr 2019 11:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556624955; bh=1E80f6C6KKklPmtdQ4vXPcXRkfI+cNj4GBx96Yoj1oI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fRtuQDYn6xfE49zUFpizY4Tii9N4784pnEDc+qogpjYAaZjlUg03iHvYFGqe1B/WL zT3ITcbbAAbQgfOFAluXm0pe+5RGQSpuEk2v2UOhSq3qtp6T9mMc5m92Sud6yRJyoF fx7l5CJvdMjuG55JHtItlN2tdmR/GMK+o+i5xfXo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lucas Stach , Philipp Zabel , Dmitry Torokhov Subject: [PATCH 5.0 35/89] Input: synaptics-rmi4 - write config register values to the right offset Date: Tue, 30 Apr 2019 13:38:26 +0200 Message-Id: <20190430113611.514987684@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430113609.741196396@linuxfoundation.org> References: <20190430113609.741196396@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lucas Stach commit 3a349763cf11e63534b8f2d302f2d0c790566497 upstream. Currently any changed config register values don't take effect, as the function to write them back is called with the wrong register offset. Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D sensors and F11) Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/rmi4/rmi_f11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/rmi4/rmi_f11.c +++ b/drivers/input/rmi4/rmi_f11.c @@ -1230,7 +1230,7 @@ static int rmi_f11_initialize(struct rmi } rc = f11_write_control_regs(fn, &f11->sens_query, - &f11->dev_controls, fn->fd.query_base_addr); + &f11->dev_controls, fn->fd.control_base_addr); if (rc) dev_warn(&fn->dev, "Failed to write control registers\n");