Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4814020yba; Tue, 30 Apr 2019 04:58:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLJzZZit5YuzDYRAC7VJVgbN4G31/FW6YkqLHoVvWSCzS6UqBXhVwlamMcRPHKs+gTe7qJ X-Received: by 2002:a63:c601:: with SMTP id w1mr16477716pgg.190.1556625483415; Tue, 30 Apr 2019 04:58:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556625483; cv=none; d=google.com; s=arc-20160816; b=yDa0CEjA27rIXzLANron0GX+FgIob67pc9xYwj6pDJOljat/iHBhPyC6BUitYFvQEP XXMlziJ9m7z5VvJhFahcQK2zg4wcObQceIuusErp5DieOnNN/u/MNNxKR/TYL1k741Fr E2YmD624xPUx/LjQUs5Ue4pHeZON0bKmVfiZfpxFmhW1ztTP6qRWaOG1I4P5TOIEqio8 4M1Hde67mpbUDsLzXTzmq6bwyD4oqqnOgBRyiRDvnx9XO8hElqdszbYmQHFsJ20Z10mg O2uetz57IvZ9+Ra7BW57L8oiW25AIottlQ3l0DM6KleK2K5HNMYslTFFEwXvUQx2Dwf4 fNBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sW1JaRuWoHJrNc7hDUHrDER0V+57t3YVf38TvVMcmvs=; b=rN9+lv1H5JpiTEzHx7rs9DAlFuZ11yRrpEnojZ/gdbEWGO8cFuwEi+9OqvmQ2+e8M8 Jk1u5fZMyVeT09ORU05OJt5Vbof/7deWjf7Fe1GCcdz4isnrJMgStRz1r6Mc68bNfeUw MALjwFpiwa2QtAiirMyZ1QtxVvUjgIFW37ytp2NL+JVAzhxv/3NULoNfIwCoNFSwzM/C iy2t6RStYOBZLULHUIlPel3HSufx5BleHCmmzZ4wqD0QyZDscXlQ4GpAp84af+2936xY 60ZtK3gL5Mnj5bgFwrZlPv+NQx4SHnpgBYWPKyH2rdHk2iWtwKwFCgtGz23XsWTFSCuu TEHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="wLYNtE5/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3si35295576pgc.98.2019.04.30.04.57.47; Tue, 30 Apr 2019 04:58:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="wLYNtE5/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731054AbfD3Lts (ORCPT + 99 others); Tue, 30 Apr 2019 07:49:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:36376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731042AbfD3Lto (ORCPT ); Tue, 30 Apr 2019 07:49:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 745E321734; Tue, 30 Apr 2019 11:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556624984; bh=NVg/Po1aldyrbB/KY8mC5/wJ69EYdh7+kZXSQdsRLQ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wLYNtE5/IRKg1igtZNmWP3ZobwP6pkCC5YhGoBXvEAry/Zu/gKmhAejFUMkZnnFo9 pl3JqJ5306cn42ljovWbm7tXHi5z3OP0QGYfXPdS0FUGaoOB5l7RyPLLCQva9T6LFg uGy3hsNt8KRKAFJTqY9ETWD0P29uxVzg1/bNQy5s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maarten Lankhorst , kbuild test robot , Eric Anholt , Daniel Vetter Subject: [PATCH 5.0 45/89] drm/vc4: Fix compilation error reported by kbuild test bot Date: Tue, 30 Apr 2019 13:38:36 +0200 Message-Id: <20190430113611.854265437@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430113609.741196396@linuxfoundation.org> References: <20190430113609.741196396@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maarten Lankhorst commit 462ce5d963f18b71c63f6b7730a35a2ee5273540 upstream. A pointer to crtc was missing, resulting in the following build error: drivers/gpu/drm/vc4/vc4_crtc.c:1045:44: sparse: sparse: incorrect type in argument 1 (different base types) drivers/gpu/drm/vc4/vc4_crtc.c:1045:44: sparse: expected struct drm_crtc *crtc drivers/gpu/drm/vc4/vc4_crtc.c:1045:44: sparse: got struct drm_crtc_state *state drivers/gpu/drm/vc4/vc4_crtc.c:1045:39: sparse: sparse: not enough arguments for function vc4_crtc_destroy_state Signed-off-by: Maarten Lankhorst Reported-by: kbuild test robot Cc: Eric Anholt Link: https://patchwork.freedesktop.org/patch/msgid/2b6ed5e6-81b0-4276-8860-870b54ca3262@linux.intel.com Fixes: d08106796a78 ("drm/vc4: Fix memory leak during gpu reset.") Cc: # v4.6+ Acked-by: Daniel Vetter Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -999,7 +999,7 @@ static void vc4_crtc_reset(struct drm_crtc *crtc) { if (crtc->state) - vc4_crtc_destroy_state(crtc->state); + vc4_crtc_destroy_state(crtc, crtc->state); crtc->state = kzalloc(sizeof(struct vc4_crtc_state), GFP_KERNEL); if (crtc->state)