Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4816621yba; Tue, 30 Apr 2019 05:00:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxGc3xsjDrU4/sDtqbszoGQpzICMUDJLr4QY3DHzgGTPdufoR7ulCh8UCXXjVji2CGhs+eg X-Received: by 2002:a17:902:e48b:: with SMTP id cj11mr25780078plb.223.1556625645909; Tue, 30 Apr 2019 05:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556625645; cv=none; d=google.com; s=arc-20160816; b=HTCYBJPYY1SYXlb+1IQlrQjt4OgpeIbpMuhedK1sp0Y1nCnewPBDcnhu2XwIHT7n8H HGqhlX1w5dmfO8CsFfeIqOXO+B9mnpO2sYo3UNwHCtDW2MYx82/uvb4Zv9Z5QE3w5aHO sOvIx5sgUqS3NGdsZCo0CnT1VEu6K/2OIM9XzQ+EXAcy6PL8hDl1LxtBn4A7qKPxOfPl rSctcoaaPhV8c1cTwxotQnpIEWQqtNDbxfD/pypbhlXBHSAwlBfh5+GwjNvjznPa703g 2O0sHeCwW9fnFY0XC0ffL0JL8lPpSnFV6nabbYzzqR7k6XZ5pxoaYYol94gs1ocV8NMg 1Giw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=2cc4zOE4lgn66y2b9w8w442+/1rd0a1CxMY0WlC7I/0=; b=FXKGHNhSEPdES8GX92V0wVkGq2jYrYHY21ps6BykMFrACcV0E/FcBxcQ/hAofcCtzX YKcYyCEH/FjACP7p+RfHbPy33bCkW0to6rJeZubn3Pvzs0w7eAhaC9vpGsMgwKZqwvQO 6vtw66gF9jZp8mtSdHrvzTxvCu5xJMt/2nlGIY/7Deag0ERhvM5bwtqiBPc8nZ7ausHq oRlgxwltOkhW/G4AgYTVXFik6X99YIQv/yj0tmVBEjGJGNywVNlhMRDr7g1vDszgyCmp 3RZyzeK4YLT3Dea0jHq1LwqVn3leX4ex8OAi9HGPrlyqt1xxkE3Vvbwve1RnBUfWKNcd tedQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m134si35558631pga.588.2019.04.30.05.00.29; Tue, 30 Apr 2019 05:00:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728126AbfD3L6q (ORCPT + 99 others); Tue, 30 Apr 2019 07:58:46 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:35847 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730650AbfD3LrE (ORCPT ); Tue, 30 Apr 2019 07:47:04 -0400 X-Originating-IP: 109.213.14.175 Received: from localhost (alyon-652-1-31-175.w109-213.abo.wanadoo.fr [109.213.14.175]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 1D5E31C000C; Tue, 30 Apr 2019 11:47:02 +0000 (UTC) Date: Tue, 30 Apr 2019 13:47:02 +0200 From: Alexandre Belloni To: Baruch Siach Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] rtc: digicolor: set range Message-ID: <20190430114702.GD11339@piout.net> References: <20190430093212.28425-1-alexandre.belloni@bootlin.com> <20190430093212.28425-2-alexandre.belloni@bootlin.com> <877ebbu3lz.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877ebbu3lz.fsf@tarshish> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/04/2019 14:36:24+0300, Baruch Siach wrote: > Hi Alexandre, > > On Tue, Apr 30 2019, Alexandre Belloni wrote: > > > While the range of REFERENCE + TIME is actually 33 bits, the counter > > itself (TIME) is a 32-bits seconds counter. > > > > Signed-off-by: Alexandre Belloni > > --- > > drivers/rtc/rtc-digicolor.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c > > index 5bb14c56bc9a..e6e16aaac254 100644 > > --- a/drivers/rtc/rtc-digicolor.c > > +++ b/drivers/rtc/rtc-digicolor.c > > @@ -206,6 +206,7 @@ static int __init dc_rtc_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, rtc); > > > > rtc->rtc_dev->ops = &dc_rtc_ops; > > + rtc->rtc_dev->range_max = U32_MAX; > > Where can I find documentation on the meaning and usage of the range_max > value? I could not find anything in the kernel source. > It should be set to the maximum UNIX timestamp the RTC can be set to while keeping range_min to range_max contiguous. In the digicolor case, you could go up to 8589934590 (Wed Mar 16 12:56:30 UTC 2242) but the driver only writes DC_RTC_REFERENCE and I'm not sure it can also update DC_RTC_TIME safely. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com