Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4830214yba; Tue, 30 Apr 2019 05:11:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmkbntYCsahR3wyIsgEYiQtMqLA5wgiKJwsKsQcl+idcgNIrbkYYCxw+MILl3gNZfRL0WA X-Received: by 2002:a17:902:e407:: with SMTP id ci7mr24301904plb.219.1556626288601; Tue, 30 Apr 2019 05:11:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556626288; cv=none; d=google.com; s=arc-20160816; b=HM757hRrXOlv3Cswuts6A2TIXTaXI28S1xkoJ3LY3w4CsBf76fnT9H3K6TArvrYvp8 nqGkQ89+DMEfwmY5pDPhTT+uo62GeVMMecYDV0886jtJ1EjMgQr6wguRbVQf9EeCzwjV MQ8ooQtVOOSKkMgB1jjdlwsAxBfUDAJFFgSNTxyB9jlbah45ZzJRbM2VqZRPBxlQhoRZ 6VfBjk/YjfPglwFaH1HhQyTYW8z7B2CJXJA0Kpc/2ykNVZLv/0/08m3PYaqPNnE60qYX DcbPNKwN7YKQ5Ep14EEvesz+XeM221M0Hy2ygi6ulxCfCk1rFvoYh8sCi2Xplo1lsbZh Sg9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dN6hlN1qnfHl6R4lgnXPMx33e1+0DrLeIm0IeObPFMU=; b=hSsNeGQytZopUi1TSugC9I5SjCQjJ3F7+lQAJ7s3C4wR6QXyQ6eS94ENgWe6NsetwA +DVWoGB/QInITYIWDcAFJMJJRKkOerKW0o0xuzV2IFNTsRDRdHcwH4G9cONuBt1ZTZUl U6Y2eR/jNPlwNenWDjCwekAUlJpsmWgpJT8G+liUDyk8qwh1rX5LfAn6ZIKVJs5OLIHO BGWAGLVtxchbxUM3vnFlcMP49OLRkVW2i+x4E34qfs7ymT3C/lKbxFflQEnO7bl8whdi GNBbb3xbgadf/2kxtvDNZcxCPAPKYblVZn0oFGGsS2rQ7OWPs9Qw6nIfFw5MWC6fUMVx iPKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XBK7yn+v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d25si35260417pgb.229.2019.04.30.05.11.10; Tue, 30 Apr 2019 05:11:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XBK7yn+v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbfD3MIz (ORCPT + 99 others); Tue, 30 Apr 2019 08:08:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:45044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727900AbfD3Ljh (ORCPT ); Tue, 30 Apr 2019 07:39:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71A2721670; Tue, 30 Apr 2019 11:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556624376; bh=PEIgw3Yh8ZrVsMbK1As2iNlmAjYgmsm6n/R4kCwIOaE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XBK7yn+vVEXbb1xL1TRVCe0CClfLZzH0b+2ArYVDXRApOO0pzkiY7nWIqJ2qk4NDb EgnRgYFbaxiOWZTWlQc2qHORzddoR4Cfbx+KWZBS9fg1wPp/Wu5bqg2LrltmrTDnT1 eOU7g1x/AyOwfGozT3hBQiM5Czi+3COw0UYeV4Sg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lucas Stach , Philipp Zabel , Dmitry Torokhov Subject: [PATCH 4.9 12/41] Input: synaptics-rmi4 - write config register values to the right offset Date: Tue, 30 Apr 2019 13:38:23 +0200 Message-Id: <20190430113527.894541355@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430113524.451237916@linuxfoundation.org> References: <20190430113524.451237916@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lucas Stach commit 3a349763cf11e63534b8f2d302f2d0c790566497 upstream. Currently any changed config register values don't take effect, as the function to write them back is called with the wrong register offset. Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D sensors and F11) Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/rmi4/rmi_f11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/rmi4/rmi_f11.c +++ b/drivers/input/rmi4/rmi_f11.c @@ -1198,7 +1198,7 @@ static int rmi_f11_initialize(struct rmi ctrl->ctrl0_11[11] = ctrl->ctrl0_11[11] & ~BIT(0); rc = f11_write_control_regs(fn, &f11->sens_query, - &f11->dev_controls, fn->fd.query_base_addr); + &f11->dev_controls, fn->fd.control_base_addr); if (rc) dev_warn(&fn->dev, "Failed to write control registers\n");