Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4838379yba; Tue, 30 Apr 2019 05:18:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwn44/h+Ji46NDWA4DXnl4VX38HAMLJ4AhLCFbewvvS6BGC7D3weMw+dvsoC6mdNzE1/e/x X-Received: by 2002:a63:e051:: with SMTP id n17mr22975192pgj.19.1556626733818; Tue, 30 Apr 2019 05:18:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556626733; cv=none; d=google.com; s=arc-20160816; b=ST1lnlLfIAb1ormN3r40eowYNuigoZpMhPxyAqQeywN2Dgb80QohSLlpEVEsLrHv8r blf77K6XC++S+BWAAXAht5J41+p7VY9cjDmgi0vVUiR6DSHephRRT32X0mHGliAKsB38 qKZxQZ/SKPifT1nv+g8NRYELYBs9yKINmuALGum/Lg8T6MDP00hCM/g/Y68cyV7K+s+e fWmniSspmLzlejCU3SiTsek06I/aKanhDRm5qgSeij7v1Po3aB5E6YqAF109+c1wbdZE VwlZnEpGu5qQMDop3q6Qe6MB5ag6No4XdlqEhQmtAhwfRZaPbXVZKfiyQHyUABgFGrgF 8uqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=g4RgZMXHLlKK/1c4ZBuHDrgS/JTY9zZ6KxD68Uc2FF0=; b=MDoGxzKMw1tP0Vx83nvPgbUhNe0WXTR2HAoUBk8p5FLdTSlMVMEtBrcHAerwswDQ6P gXBVT3oVd1vQpaB3u88FeO9Vurpae90vbol6NBkKHI/24q/0s2EUIkPQ29tnczY9hnwC sBQF1x25cmio122/MgrRWMplOM7xruI/lIQZAk0hzvjeDTXkpISlnWbrGLaE07zpfhJ8 kfZ5Yalv5smNUIMvy4d7pLW1Hd2TFHp3iWzISl1VUWqLcMKmvSyhFZ+k+kaS+papwk4z hJj7QYjiR372wHPSn3I74NAx67987a8vp8BSm66sjBx8mLt4oq2YKvIe0XlKxIUga2wq BMBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NqWiNKJ7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t21si4526190pgm.438.2019.04.30.05.18.36; Tue, 30 Apr 2019 05:18:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NqWiNKJ7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727341AbfD3MQR (ORCPT + 99 others); Tue, 30 Apr 2019 08:16:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:37122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbfD3MQQ (ORCPT ); Tue, 30 Apr 2019 08:16:16 -0400 Received: from linux-8ccs (p5B164EF0.dip0.t-ipconnect.de [91.22.78.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05575205ED; Tue, 30 Apr 2019 12:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556626576; bh=H4/4dT9BDXgmTLrM3JhAKhMqwOU404G2VfdlNa7qgMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NqWiNKJ7KoJAip0wlu4QLyfLHyp7plR4731w4+lsTQnR4TTWkDySwGLqU9Xt37xkU ZlaBOi61KqfcBVBxvO19pFa8zNBqnDWaVOOcErmKr252MgY4rHMNpfFA9pKGNx7aoM AV130XZMq8j8J1ZMC64B7iz5o3nTWZqS+FGOXTk8= Date: Tue, 30 Apr 2019 14:16:11 +0200 From: Jessica Yu To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel/module: Reschedule while waiting for modules to finish loading Message-ID: <20190430121611.GA29488@linux-8ccs> References: <20190429151751.15424-1-prarit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190429151751.15424-1-prarit@redhat.com> X-OS: Linux linux-8ccs 5.1.0-rc1-lp150.12.28-default+ x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Prarit Bhargava [29/04/19 11:17 -0400]: >Heiko, do you want a Signed-off-by or a Reported-by? Either one works >for me. > >P. > >----8<---- > >On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while >loading the s390_trng.ko module. > >Add a reschedule point to the loop that waits for modules to complete >loading. > >Reported-by: Heiko Carstens >Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading") >Signed-off-by: Prarit Bhargava >Cc: Jessica Yu Thanks for the fix! Applied to modules-next. Jessica