Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5017124yba; Tue, 30 Apr 2019 07:56:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1D6IEIbv/ODSFnLzno8W0jJsEcRCipeKcLjjV30NWkIL/oE5v0F5XzCW4h91NeUXVHWgt X-Received: by 2002:a63:2bc8:: with SMTP id r191mr30891310pgr.72.1556636162498; Tue, 30 Apr 2019 07:56:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556636162; cv=none; d=google.com; s=arc-20160816; b=lLBr0Q3RLexqExmBHt/0TEMqXQnY4vPdH6zognMkMfxKslApFalKEFuMugVQ739594 Fv57r1x5hpWLtxgVCD19xL4d+9lrmq/si/HmHKBv1wCDWxi6j2jKf7gVMZ4oG85/Xykh WKs5Dt+wIylPknxSD7ESsKkFkPmQRq5auUHoFGYJUs6gK/qQlLFtDSdYyZXgGs6kN3d5 80SPgiyrkWviByfoYvtoHKrBuKgQhCBJnfgJVXCCi7926jNjWoMUOM8ID03A1BGbXNv5 PKwyaqXgUKIIZPXEfj8UigLw3lLKhLmm1u328QQwNE/6BKDuoR+3z2jR0MViiS5xrooq Nkvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=gFvRPvsQnJ+vDnP8hbbQ4addtxbLVWeILsdtCEHk1V8=; b=nLf1QxWgBQnCqjNwKOLg3xcoOwYBg8AOoBcf+zGG//QysgfKt+uFN+AI6dfEkjRIsX Ro7zULPfOHHvg0qoMzfrxZ6jW7vJ1+lolmZmF2KRdG2CpujdOPru0NwZd2atRrPvWkUs JZm5O26Rhyv+0OpXWsdzg8SVxNkjTZctYeoxct9kw7UPCHC9VMhWCVHHjP4cFOpkTuha JeamxxftsEby6lgoJ4YYuNKtUtKvmvii7FXJp1bcvCBokC3rBMd7cfbj/Ux5duBf35VN pzwCaUcSDm5Ml5flgiCgD2A2U3OeIyawQSWaCskVsb17VCvnXg2OjddlsX5b2hRijows wXhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9si32190023pgp.258.2019.04.30.07.55.46; Tue, 30 Apr 2019 07:56:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbfD3Oxw (ORCPT + 99 others); Tue, 30 Apr 2019 10:53:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37484 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbfD3Oxw (ORCPT ); Tue, 30 Apr 2019 10:53:52 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3ABC2D3C0A; Tue, 30 Apr 2019 14:53:52 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.159]) by smtp.corp.redhat.com (Postfix) with SMTP id 2A9686F57D; Tue, 30 Apr 2019 14:53:46 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 30 Apr 2019 16:53:50 +0200 (CEST) Date: Tue, 30 Apr 2019 16:53:43 +0200 From: Oleg Nesterov To: Peter Zijlstra Cc: Sebastian Andrzej Siewior , linux-rt-users , LKML , Thomas Gleixner , Daniel Bristot de Oliveira , Clark Williams , Juri Lelli , jack@suse.com Subject: Re: [RT WARNING] DEBUG_LOCKS_WARN_ON(rt_mutex_owner(lock) != current) with fsfreeze (4.19.25-rt16) Message-ID: <20190430145343.GG23020@redhat.com> References: <20190326093421.GA29508@localhost.localdomain> <20190419085627.GI4742@localhost.localdomain> <20190430125130.uw7mhdnsoqr2v3gf@linutronix.de> <20190430132811.GB2589@hirez.programming.kicks-ass.net> <20190430141500.GE23020@redhat.com> <20190430144252.GF23020@redhat.com> <20190430144457.GJ2589@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430144457.GJ2589@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 30 Apr 2019 14:53:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/30, Peter Zijlstra wrote: > > On Tue, Apr 30, 2019 at 04:42:53PM +0200, Oleg Nesterov wrote: > > I have cloned linux-rt-devel.git > > > > If I understand correctly, in rt rw_semaphore is actually defined in rwsem_rt.h > > so percpu_rwsem_acquire() should probably do > > > > sem->rw_sem.rtmutex.owner = current; > > That'll screw the PI chain (if there is one), right? Yes, I have already realized this can't work after I glanced at this code, thanks. Oleg.