Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5036913yba; Tue, 30 Apr 2019 08:11:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqwg7LiYHwGRMCF7zHpuZOjtUQxlaKM3JFBUJoJMmyPDHi4Xtinjk0L9gluBJE8c5ZXSdcfd X-Received: by 2002:a62:ee0a:: with SMTP id e10mr70289744pfi.6.1556637099144; Tue, 30 Apr 2019 08:11:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556637099; cv=none; d=google.com; s=arc-20160816; b=RDw6AIpoUoOMZ6Q/1toYSWhU3VfEpgTc22pWmoJCtUWDwkH1oaynq2/vmhHhv719N4 QPpNBJfrC8ZHeOPxH4KFcwPqZzhSKDMmZNWM4kflFkYmwQS685ZWWiU1BlwFE7j5eMgr Oz/SY+0oqKNiZybvLYQ4nmHnd0oO5TOYEG6i0G7TIVM+9zyN/lgUaG5BbyQd6aKC5cUF p7hmGhxpNDJc3dSFc9Zt3K8OYN9r2ZBVcgS3C19AfHiyNsgNsWysi2nRXJm0b0P5SWcu TRDkzWEoBlQNOKIL8pIN7SU+xBnt7LbrjjihOc3kIi6w79sKdWY0KaX7ZGjCN1xtYrTC n5Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=lQG7ER3CF2NhDacQi88MHZXIYA79ZZ+9HquKpd7ZVqg=; b=HP0ZYcFnLERyXf+0H1La6HDs5Xtl9v+zUtZB9QHo5Qq1CCkILe7bBhwJuDnaUaTN2G qPhi6WhbSuRj0fQezG8PDObsDM9qSHTJJkhh8TlV/ShXkLnKPME9ticeY3gnQMBwIJOG 2J7GcivBEeKpgmGy57Lmtopojq1oqXvuO2wQ8Pr23loCR9kMbeVXFZotq5b1GxsKw8yg EQmK9ZpXOeA6hm7Oyk6eatOXp8vT58H1AUReOL3klnEF835Nz30PduY/W1AtXpJCsGJg qlg0C2AlHFDTBhJCPikAS9nI6mm574vfXgUy+DW7K4UAfDX3BKhn4r0IdPKkJeflK+Et WUUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b18si26905263pgb.162.2019.04.30.08.11.20; Tue, 30 Apr 2019 08:11:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726897AbfD3PIP (ORCPT + 99 others); Tue, 30 Apr 2019 11:08:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:58536 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726050AbfD3PIN (ORCPT ); Tue, 30 Apr 2019 11:08:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2AA3DAD31; Tue, 30 Apr 2019 15:08:12 +0000 (UTC) Date: Tue, 30 Apr 2019 17:08:11 +0200 From: Petr Mladek To: "Tobin C. Harding" Cc: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Greg Kroah-Hartman , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] livepatch: Use correct kobject cleanup function Message-ID: <20190430150811.4hzhtz4w46o6numh@pathway.suse.cz> References: <20190430001534.26246-1-tobin@kernel.org> <20190430001534.26246-3-tobin@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430001534.26246-3-tobin@kernel.org> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2019-04-30 10:15:34, Tobin C. Harding wrote: > The correct cleanup function after a call to kobject_init_and_add() has > succeeded is kobject_del() _not_ kobject_put(). kobject_del() calls > kobject_put(). Really? I see only kobject_put(kobj->parent) in kobject_del. It decreases a reference of the _parent_ object and not the given one. Also the section "Kobject removal" in Documentation/kobject.txt says that kobject_del() is for two-stage removal. kobject_put() still needs to get called at a later time. IMHO, this patch causes that kobject_put() would never get called. That said, we could probably make the removal a bit cleaner by using kobject_del() in klp_free_patch_start() and kobject_put() in klp_free_patch_finish(). But I have to think more about it. Best Regards, Petr