Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030200AbVKHHfH (ORCPT ); Tue, 8 Nov 2005 02:35:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965098AbVKHHfH (ORCPT ); Tue, 8 Nov 2005 02:35:07 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:63944 "EHLO mail.cs.helsinki.fi") by vger.kernel.org with ESMTP id S965070AbVKHHfF (ORCPT ); Tue, 8 Nov 2005 02:35:05 -0500 Date: Tue, 8 Nov 2005 09:34:48 +0200 (EET) From: Pekka J Enberg To: Roland Dreier cc: Matthew Dobson , kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] Cleanup kmem_cache_create() In-Reply-To: <52mzkfrily.fsf@cisco.com> Message-ID: References: <436FF51D.8080509@us.ibm.com> <436FF70D.6040604@us.ibm.com> <52mzkfrily.fsf@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 17 On Mon, 7 Nov 2005, Roland Dreier wrote: > > * Replace a constant (4096) with what it represents (PAGE_SIZE) > > This seems dangerous. I don't pretend to understand the slab code, > but the current code works on architectures with PAGE_SIZE != 4096. > Are you sure this change is correct? Looks ok to me except that it should be a separate patch (it is not a trivial cleanup because it changes how the code works). Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/