Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5160565yba; Tue, 30 Apr 2019 10:05:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqzofAr+YFdU8SsNiAQZJMzlrDXTZ1kY14GJVlPLyZFe5i6Yj3Q9wCcrpo3VfNiFa8LLj0Ci X-Received: by 2002:a63:5166:: with SMTP id r38mr28124654pgl.429.1556643921909; Tue, 30 Apr 2019 10:05:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556643921; cv=none; d=google.com; s=arc-20160816; b=zStfeHXR3EZlxNxqx8xoNEcUsUm3CBbV8Q3umzlDhYAr55X3MwxW9aY2wo7k/Bcchs E2SB3DCAc9y+P/9jVRTh2HKbfsQuLIZqcYXc1jFNb/Pt0R1zCNzKTj551qaUYJ7ZLrXr MI4kPXRvk1A7jOdn7TkrE6wvNJgVWptLdw2AehoPmUmrjyPnmfW62ifJa8wMVdiHK7GU Wf0+3hKRzNo8Pd4uT4e29PhwENij/8RczFkOOUFxiK94OGMJwaWuGCBQabFIGSt8sJXF bJHVAe/XJjY/2TE8h9l5u7UwsDGAuOyf0JRVyOgqkMKiteOaCFrQe/lvuIYB0v3WRZ6O 2+UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=cw+Y+kaLK7q7FJ1N0DeZMDtRi1OTaVzMwfDIbH5gM7Y=; b=HQH3gyjLxdTpnmuY3FfmIi5yAuT3AYtyW1y3M3yvo4mn1PpNepJp5oj1rNRPlc8M+8 OlSdL5seipnnwv9Ky4YJw4+tWHLgVQEAeZEvYX8K3Ea5KWzKvRp/i52ogvMNEqNNs27d zxwVyqcmJuuM8ktwNO+KNJA7I//YDMc0PR2dhwwowu9t9i6a0l0U+UZQ6Z274s/wHEKl k3yt9COneEQQhDPXa5W1cvd2wXTP2LoLaKiu9q1XPjpm6lnscW4XHmN1HiEqkmrfkpM2 JlGwmerDb1RRqM2sGfL9HkYm6FyKKowWGGASK5Q1/Ofualllz12+FSH75UREOt934mlS qjRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b="thokTpL/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10si37458295plr.137.2019.04.30.10.05.03; Tue, 30 Apr 2019 10:05:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b="thokTpL/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726602AbfD3RDk (ORCPT + 99 others); Tue, 30 Apr 2019 13:03:40 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:46650 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbfD3RDj (ORCPT ); Tue, 30 Apr 2019 13:03:39 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 44tnsz6jTpz9v084; Tue, 30 Apr 2019 19:03:35 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=thokTpL/; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id FKqMaVCQSI9R; Tue, 30 Apr 2019 19:03:35 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 44tnsz5TNtz9v0Y5; Tue, 30 Apr 2019 19:03:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1556643815; bh=cw+Y+kaLK7q7FJ1N0DeZMDtRi1OTaVzMwfDIbH5gM7Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=thokTpL/usXGt8BLX8V2bx8xWqTNVqvaxd/bd14d0oRIPi+Nz75ahCnI3zJqcb7sE cnvJnJ+Rie6rzo9bbmId8kh11O2ox3khrby3ZW0DroYbZYzqH75JjtflH6umK7BHGk PIf8qIauQL14H6yyf1kHivDOgb7L7ziv12g0y3kk= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 76D118B8F1; Tue, 30 Apr 2019 19:03:37 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id juwZzfHI02dr; Tue, 30 Apr 2019 19:03:37 +0200 (CEST) Received: from PO15451 (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D857D8B8DF; Tue, 30 Apr 2019 19:03:36 +0200 (CEST) Subject: Re: [PATCH 1/5] soc/fsl/qe: qe.c: drop useless static qualifier To: Rasmus Villemoes , Qiang Zhao , Li Yang Cc: Valentin Longchamp , "linux-kernel@vger.kernel.org" , Scott Wood , Rasmus Villemoes , Rob Herring , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" References: <20190430133615.25721-1-rasmus.villemoes@prevas.dk> <20190430133615.25721-2-rasmus.villemoes@prevas.dk> From: Christophe Leroy Message-ID: <510c1b8f-515c-1cc0-d6b5-eaeaed63b738@c-s.fr> Date: Tue, 30 Apr 2019 19:03:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190430133615.25721-2-rasmus.villemoes@prevas.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 30/04/2019 à 15:36, Rasmus Villemoes a écrit : > The local variable snum_init has no reason to have static storage duration. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Christophe Leroy > --- > drivers/soc/fsl/qe/qe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c > index 612d9c551be5..855373deb746 100644 > --- a/drivers/soc/fsl/qe/qe.c > +++ b/drivers/soc/fsl/qe/qe.c > @@ -306,7 +306,7 @@ static void qe_snums_init(void) > 0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59, > 0x68, 0x69, 0x78, 0x79, 0x80, 0x81, > }; > - static const u8 *snum_init; > + const u8 *snum_init; > > qe_num_of_snum = qe_get_num_of_snums(); > >