Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5231841yba; Tue, 30 Apr 2019 11:12:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqx12F1KnNBxQU20EGGPjMMDlwhNoRFVwX5zyDpnoT3bERBqa9g6cJR0MH084TyDJwPnrKiu X-Received: by 2002:a17:902:b095:: with SMTP id p21mr39485944plr.40.1556647926635; Tue, 30 Apr 2019 11:12:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556647926; cv=none; d=google.com; s=arc-20160816; b=fDxVmE2srulE63sGvWRukkCZs8jnO0xH3F2xnvb80xV7q4xtSd1qyBYgf/h889KMNt evZZ4ckB3C005euPF4KjIe0H/PMT/diXQi2o03qTwpKNAEn0qoo59f3HgNAFWs0gpvb5 BHHiesBe1MmfNA5mqRfTaEyFtAXzmX56jmZhQJCsQ88HRpMPah2fX9wq/QJWiRG2Lfe0 O14JvD8aMo4qTj0Y35jXKyjHvxao934Y/J3MXng95UyGZt5TonIJ3pPcnk3zzQyWE/S0 Sf2FX7o7p5Im+snYFxh+evYHVEZU3MFSiPASZrsHHl+Z9WrkQUoc4wEsjRZ4/Pv8IZwF ahfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=oqoUvrwlWJ4MGMzYfwdrqQhCwtUWx+FoAC5lpL7m74k=; b=tg2AylszXEnVxQKG1LOhRD9RzlcK8vy2PAxSvhKTluimy1sSuJ7Tp/uaAwsTi8Xlil W2BKaKy8kZdzutDhs+0VZydQbLRaYW7BP+tWd90NKhyAhEpXuTST9x9VsmoAvVj1/wCB 7ExaclzCevauoCQ1cb386LJlHYuVEuZQj6mLEy0LHaiuC3gi7F2AXsHVVN/Ar6pp/KM8 cKYo2B3tZnKPiJphABv/5IeI+DKwg/WYG1XCOadL5qjl7JQaoYrZFk4KjTLpPfgfEnmx iC+JK1vOxgIdDMM3C1fUvTpQpdQZ/jXhuDQU3w5ogzFgEXuhqpyEylVACAuXSdWu+bdG 0lPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m73si15456045pga.271.2019.04.30.11.11.50; Tue, 30 Apr 2019 11:12:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbfD3SK7 (ORCPT + 99 others); Tue, 30 Apr 2019 14:10:59 -0400 Received: from mga07.intel.com ([134.134.136.100]:46938 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725950AbfD3SK7 (ORCPT ); Tue, 30 Apr 2019 14:10:59 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Apr 2019 11:10:58 -0700 X-ExtLoop1: 1 Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga002.jf.intel.com with ESMTP; 30 Apr 2019 11:10:57 -0700 Date: Tue, 30 Apr 2019 12:05:09 -0600 From: Keith Busch To: Bjorn Helgaas Cc: Alex G , Lukas Wunner , Alex Williamson , Austin Bolen , Alexandru Gagniuc , Keith Busch , Shyam Iyer , Sinan Kaya , Linus Torvalds , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "PCI/LINK: Report degraded links via link bandwidth notification" Message-ID: <20190430180508.GB25654@localhost.localdomain> References: <20190429185611.121751-1-helgaas@kernel.org> <20190429185611.121751-2-helgaas@kernel.org> <20190430161151.GB145057@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430161151.GB145057@google.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 11:11:51AM -0500, Bjorn Helgaas wrote: > > I'm not convinced a revert is the best call. > > I have very limited options at this stage of the release, but I'd be > glad to hear suggestions. My concern is that if we release v5.1 > as-is, we'll spend a lot of energy on those false positives. May be too late now if the revert is queued up, but I think this feature should have been a default 'false' Kconfig bool rather than always on.