Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <8d0d12ae-ce67-5480-49be-893fbdbb6998@embeddedor.com>
References: <20190430143206.GA4035@embeddedor> <155664492283.168659.5604495418413396919@swboyd.mtv.corp.google.com> <8d0d12ae-ce67-5480-49be-893fbdbb6998@embeddedor.com>
From:   Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH] clk: imx: clk-pllv3: mark expected switch fall-throughs
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Fabio Estevam <festevam@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Message-ID: <155664823446.168659.9382397723332081174@swboyd.mtv.corp.google.com>
User-Agent: alot/0.8
Date:   Tue, 30 Apr 2019 11:17:14 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Gustavo A. R. Silva (2019-04-30 10:28:32)
>=20
>=20
> On 4/30/19 12:22 PM, Stephen Boyd wrote:
> > Quoting Gustavo A. R. Silva (2019-04-30 07:32:06)
> >> In preparation to enabling -Wimplicit-fallthrough, mark switch
> >> cases where we are expecting to fall through.
> >>
> >> This patch fixes the following warnings:
> >>
> >> drivers/clk/imx/clk-pllv3.c: In function =E2=80=98imx_clk_pllv3=E2=80=
=99:
> >> drivers/clk/imx/clk-pllv3.c:446:18: warning: this statement may fall t=
hrough [-Wimplicit-fallthrough=3D]
> >>    pll->div_shift =3D 1;
> >>    ~~~~~~~~~~~~~~~^~~
> >> drivers/clk/imx/clk-pllv3.c:447:2: note: here
> >>   case IMX_PLLV3_USB:
> >>   ^~~~
> >> drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall t=
hrough [-Wimplicit-fallthrough=3D]
> >>    pll->denom_offset =3D PLL_IMX7_DENOM_OFFSET;
> >>                      ^
> >> drivers/clk/imx/clk-pllv3.c:454:2: note: here
> >>   case IMX_PLLV3_AV:
> >>   ^~~~
> >>
> >> Warning level 3 was used: -Wimplicit-fallthrough=3D3
> >>
> >> This patch is part of the ongoing efforts to enable
> >> -Wimplicit-fallthrough.
> >>
> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >=20
> > It was sent by Anson already.
> >=20
>=20
> Did he address both warnings?
>=20

No. I added you to the thread.