Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Paul Burton <paul.burton@mips.com>
To:     Christoph Hellwig <hch@lst.de>
CC:     Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>,
        Ley Foon Tan <lftan@altera.com>,
        Michal Simek <monstr@monstr.eu>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH 5/7] MIPS: use the generic uncached segment support in
 dma-direct
Thread-Topic: [PATCH 5/7] MIPS: use the generic uncached segment support in
 dma-direct
Thread-Index: AQHU/0QLF7/q9Iq7YkyidXRkO+31J6ZVIwmA
Date:   Tue, 30 Apr 2019 20:10:43 +0000
Message-ID: <20190430201041.536amvinrcvd2wua@pburton-laptop>
References: <20190430110032.25301-1-hch@lst.de>
 <20190430110032.25301-6-hch@lst.de>
In-Reply-To: <20190430110032.25301-6-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
user-agent: NeoMutt/20180716
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [12.94.197.246]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 35a5d8c8-1a26-4e3c-c1ad-08d6cda7ec7d
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020);SRVR:MWHPR2201MB1135;
x-ms-traffictypediagnostic: MWHPR2201MB1135:
x-microsoft-antispam-prvs: <MWHPR2201MB113555E0F0052FB7F0F1CD61C13A0@MWHPR2201MB1135.namprd22.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 00235A1EEF
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(396003)(366004)(136003)(346002)(39850400004)(376002)(199004)(189003)(26005)(6486002)(11346002)(99286004)(229853002)(486006)(316002)(476003)(6436002)(478600001)(446003)(68736007)(52116002)(44832011)(7416002)(33716001)(256004)(3846002)(58126008)(8936002)(66066001)(54906003)(102836004)(6116002)(66446008)(66556008)(66476007)(6506007)(64756008)(66946007)(73956011)(386003)(71200400001)(6916009)(71190400001)(6512007)(9686003)(76176011)(53936002)(1076003)(14454004)(186003)(6246003)(81166006)(81156014)(2906002)(8676002)(97736004)(42882007)(4326008)(25786009)(305945005)(5660300002)(7736002)(41533002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR2201MB1135;H:MWHPR2201MB1277.namprd22.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: wavecomp.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: +9J+Cn3aaCVj5xe7+TQH5xq4oPaO5heVqSkVR8aFAeIardtTcJ5USai7QKjeVnqLT0dRLRKj4EL31gCR0pyAmPKEZ2mDJFgJcrSwa0YdwN4G1Q/lrzx+e8HujouiScUDKH8LASpn1gYIkDugTTgpwB2n/jihyPYVsyAGn7dNsul/9WUqElkBxG04YOE3KQL00oVsfBh3Zgel+UGJ8gYPgvfmgfSmQY+zGiaCMyJoq9c5jykYaLJ6G1Fm1MjQdHvPP06BOmiDCCJxqjgSCbG3Cs3lV8uShxawxkIuiCzi/IGtOBhJi+WJ+3k3wagiT5fh82XUblVhJoRBpwLBYSE4sh5y6EXYgCRs83nM5nAdjy/ZY12/0/6PSov58ATY8rQ2+a1N2d0pdhPwje2qhMEr65j27W/H6+9RLldNJQvdNgM=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D2BEEA2D04956B49845701064D9E0881@namprd22.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: mips.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35a5d8c8-1a26-4e3c-c1ad-08d6cda7ec7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 20:10:43.5014
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 463607d3-1db3-40a0-8a29-970c56230104
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR2201MB1135
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Christoph,

On Tue, Apr 30, 2019 at 07:00:30AM -0400, Christoph Hellwig wrote:
> diff --git a/arch/mips/mm/dma-noncoherent.c b/arch/mips/mm/dma-noncoheren=
t.c
> index f9549d2fbea3..f739f42c9d3c 100644
> --- a/arch/mips/mm/dma-noncoherent.c
> +++ b/arch/mips/mm/dma-noncoherent.c
> @@ -44,33 +44,26 @@ static inline bool cpu_needs_post_dma_flush(struct de=
vice *dev)
>  	}
>  }
> =20
> -void *arch_dma_alloc(struct device *dev, size_t size,
> -		dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs)
> +void arch_dma_prep_coherent(struct page *page, size_t size)
>  {
> -	void *ret;
> -
> -	ret =3D dma_direct_alloc_pages(dev, size, dma_handle, gfp, attrs);
> -	if (ret && !(attrs & DMA_ATTR_NON_CONSISTENT)) {
> -		dma_cache_wback_inv((unsigned long) ret, size);
> -		ret =3D (void *)UNCAC_ADDR(ret);
> -	}
> +	if (!PageHighMem(page))
> +		dma_cache_wback_inv((unsigned long)page_address(page), size);
> +}

This series looks like a nice cleanup to me - the one thing that puzzles
me is the !PageHighMem check above.

As far as I can see arch_dma_prep_coherent() should never be called with
a highmem page, so would it make more sense to either drop this check or
perhaps wrap it in a WARN_ON()?

Thanks,
    Paul