Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5352676yba; Tue, 30 Apr 2019 13:20:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtKB2gVjSjKPXOPCAR90XzQylRXMBjxionif8XZlCIotwT6FP7mo79hzFawTsV6rX40eXt X-Received: by 2002:a62:30c2:: with SMTP id w185mr7615153pfw.175.1556655614558; Tue, 30 Apr 2019 13:20:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556655614; cv=none; d=google.com; s=arc-20160816; b=dz354XzcxqfCjiIvH/RQhLTig7com7BLbadgoPLFKvGwzGPby1m4ZALV8JGV/8bkSp jJ35SbRJpKU6RTxLsGTYzDi5wgeS6HG4zZBtVOa9kHevPvOymRciQMINti21xOTK/zGp 1D6N8JDLfpur6XAiVQkfxYdxEQIH+CV5jxX/94BwZRZNGR7kBqM2h2svmvwuh0eXBbWB D0CCyHSAe4CtyX5zELha5ntJAEL4VPNGzf3o64yJAgwy8oUWwD+rtWkd72PI1VKY8KoJ KairfKif13at9+JV9RFg3Nq2tHb3gsdvPYW7lgix5+TnFIUxlGae2gLCBLO7yC2vgvit DMkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=AycnaEmXwfvWM6WqlBAVeSp7MdJyKYBDKCun3bdhbCk=; b=O7CfL7LGc1v4GAoeOvn4WQkzpFt10ViBSnbAzsU4+sGCC5IbY6KjX74VwENoyXBMk+ DRmJ20oszVJt9CzMfIieneHOP1Idcp58VP4FMDOgZGI/kajn1fFB5HRzvtt67lSUwW25 VMWZFZeq2B0/COW14uHt7+/ubvCD9/VY0Wkdt+b1D+7OdUpn+eZoZtoMv24ph6oMi3+4 m06c2vXqdLTyPDUXBL8vEAgHxXIXat2/GYYlRBsZaY2L2WnVDR2O13tmECtmZPShUp/O hnTJP+zuiBA2/OuPWdo/bZFN6lAzWlyr1736duPgnk1vruTUBm1LDV11fW1EJ8YMoVjK ZOKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8si37270653plk.108.2019.04.30.13.19.58; Tue, 30 Apr 2019 13:20:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726263AbfD3UTF (ORCPT + 99 others); Tue, 30 Apr 2019 16:19:05 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47659 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbfD3UTF (ORCPT ); Tue, 30 Apr 2019 16:19:05 -0400 X-Originating-IP: 90.66.53.80 Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5A297E0008; Tue, 30 Apr 2019 20:19:02 +0000 (UTC) From: Alexandre Belloni To: linux-rtc@vger.kernel.org, Patrice Chotard Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH] rtc: st-lpc: remove unnecessary check Date: Tue, 30 Apr 2019 22:18:34 +0200 Message-Id: <20190430201834.12634-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core already ensures the alarm is set to a time in the future, it is not necessary to check again in the driver. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-st-lpc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/rtc/rtc-st-lpc.c b/drivers/rtc/rtc-st-lpc.c index bee75ca7ff79..ce2dae6e2a24 100644 --- a/drivers/rtc/rtc-st-lpc.c +++ b/drivers/rtc/rtc-st-lpc.c @@ -166,10 +166,6 @@ static int st_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *t) now_secs = rtc_tm_to_time64(&now); alarm_secs = rtc_tm_to_time64(&t->time); - /* Invalid alarm time */ - if (now_secs > alarm_secs) - return -EINVAL; - memcpy(&rtc->alarm, t, sizeof(struct rtc_wkalrm)); /* Now many secs to fire */ -- 2.20.1