Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 01 May 2019 08:52:55 +1000
From:   Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH] powerpc: vdso: drop unnecessary cc-ldoption
To:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Paul Mackerras <paulus@samba.org>
Cc:     Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
        clang-built-linux <clang-built-linux@googlegroups.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linuxppc-dev@lists.ozlabs.org,
        Masahiro Yamada <yamada.masahiro@socionext.com>
References: <20190423211116.261111-1-ndesaulniers@google.com>
        <CAKwvOd=dBLXQUzv8R3-JqF=pUTH0-5O3v+_ceekT3W23VxtDbg@mail.gmail.com>
In-Reply-To: <CAKwvOd=dBLXQUzv8R3-JqF=pUTH0-5O3v+_ceekT3W23VxtDbg@mail.gmail.com>
MIME-Version: 1.0
User-Agent: astroid/0.14.0 (https://github.com/astroidmail/astroid)
Message-Id: <1556664541.74fhfupxpn.astroid@bobo.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Nick Desaulniers's on May 1, 2019 6:25 am:
> On Tue, Apr 23, 2019 at 2:11 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
>>
>> Towards the goal of removing cc-ldoption, it seems that --hash-style=3D
>> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
>> of binutils for the kernel according to
>> Documentation/process/changes.rst is 2.20.
>>
>> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
>> Cc: clang-built-linux@googlegroups.com
>> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>> ---
>>  arch/powerpc/kernel/vdso32/Makefile | 5 ++---
>>  arch/powerpc/kernel/vdso64/Makefile | 5 ++---
>>  2 files changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/vdso32/Makefile b/arch/powerpc/kernel/v=
dso32/Makefile
>> index ce199f6e4256..06f54d947057 100644
>> --- a/arch/powerpc/kernel/vdso32/Makefile
>> +++ b/arch/powerpc/kernel/vdso32/Makefile
>> @@ -26,9 +26,8 @@ GCOV_PROFILE :=3D n
>>  KCOV_INSTRUMENT :=3D n
>>  UBSAN_SANITIZE :=3D n
>>
>> -ccflags-y :=3D -shared -fno-common -fno-builtin
>> -ccflags-y +=3D -nostdlib -Wl,-soname=3Dlinux-vdso32.so.1 \
>> -               $(call cc-ldoption, -Wl$(comma)--hash-style=3Dboth)
>> +ccflags-y :=3D -shared -fno-common -fno-builtin -nostdlib \
>> +       -Wl,-soname=3Dlinux-vdso32.so.1 -Wl,--hash-style=3Dboth
>>  asflags-y :=3D -D__VDSO32__ -s
>>
>>  obj-y +=3D vdso32_wrapper.o
>> diff --git a/arch/powerpc/kernel/vdso64/Makefile b/arch/powerpc/kernel/v=
dso64/Makefile
>> index 28e7d112aa2f..32ebb3522ea1 100644
>> --- a/arch/powerpc/kernel/vdso64/Makefile
>> +++ b/arch/powerpc/kernel/vdso64/Makefile
>> @@ -12,9 +12,8 @@ GCOV_PROFILE :=3D n
>>  KCOV_INSTRUMENT :=3D n
>>  UBSAN_SANITIZE :=3D n
>>
>> -ccflags-y :=3D -shared -fno-common -fno-builtin
>> -ccflags-y +=3D -nostdlib -Wl,-soname=3Dlinux-vdso64.so.1 \
>> -               $(call cc-ldoption, -Wl$(comma)--hash-style=3Dboth)
>> +ccflags-y :=3D -shared -fno-common -fno-builtin -nostdlib \
>> +       -Wl,-soname=3Dlinux-vdso64.so.1 -Wl,--hash-style=3Dboth
>>  asflags-y :=3D -D__VDSO64__ -s
>>
>>  obj-y +=3D vdso64_wrapper.o
>> --
>> 2.21.0.593.g511ec345e18-goog
>>
>=20
> bumping for review

This looks like a good cleanup.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

=