Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6141604yba; Wed, 1 May 2019 06:50:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKDgJ07AQZau/69yC6aotQo+oac+iUsMSC6WtQw78ttjf8cjjXtRug/S4lkDqOGgGZJis2 X-Received: by 2002:a63:c10d:: with SMTP id w13mr73215711pgf.311.1556718604967; Wed, 01 May 2019 06:50:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556718604; cv=none; d=google.com; s=arc-20160816; b=UwwHCOj9iYvebsxTBGtwCc/7/82hjpA/c0bPhM1ehbqx0ti186NHSTr6GgMXg90WKS MWijfM3zvJmA8hw2Z0RPGNup4T7oeQmrnoHNtO+So/FTSAv4Bz70RqxeTifgBhsh/y+S Nd5kDukekbii/dnwbQ30dNQPsU4TupbH1nlt3QRrGBDgve/Jn9dif/9DuVbIE1pMphLI UUERNFeU3/HekomJTLEsDBBIq78tgcjtjUZ/oWXA/LWcCrlPls0yWKOfMXEnKvAMU6gv Mr0FUTqvhVQXEQ6ds776YF7FQRTqLeVlFY0JV31N/p40Or5+tM6wSBq/TrN4js/mYSDo Uz9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UtHOeq7UKgkwJ5cmPkO6mA+wJVx0zp2ypCl6r53C874=; b=TLOe049iD15QB67052P1qLnGgbcYGiuGoJ6VazzM9+/26FSWn06zc9IhGOQ0mrnPTZ GolvpR7VLmVq87l+PGoINCJDrg0IwNU75Ik3vw+R5uwKrWaOreZBogk9DF7COHfpWm4n boAnkQxsbiZ5kM0O4ql48u1tIDNhkWmKk4PyNR8R9IjrNB/qs3Yplx0H5t3OZShNoDgk SGNJgdnpoj0ax7jrXMlIkXJ+coIPWCuDLrWYmuhMttA6UpJleNYLd6bz78TbQmt7qkWY bzFI722yPgvPeDetqSqoqTIxkQHXxk/3/KHZocNexDQ+PjWogyndn7h96O6V3Ejo7pn5 fPow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=s9c8uTch; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 60si41698802pla.335.2019.05.01.06.49.49; Wed, 01 May 2019 06:50:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=s9c8uTch; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726584AbfEANsh (ORCPT + 99 others); Wed, 1 May 2019 09:48:37 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33968 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726101AbfEANsg (ORCPT ); Wed, 1 May 2019 09:48:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UtHOeq7UKgkwJ5cmPkO6mA+wJVx0zp2ypCl6r53C874=; b=s9c8uTchNsADzr9NCHty54SmZ EhbjZ/+kbx3FvTSuTQM9OXhZZx14R98MBdwA3toWG366WTGOC5oL7vJsg/aXg63cwUhiaYsNLvBhj y3/+J2YEw/92Z/8qXN+u2ab25KOyxpuQRMdabxu01Po0ak96sAkXKJLJ//rTlVR6qx2b8bJ8qO26X AuIwPCdAwQSwW68isgzZhAzgNED74dCWMxWYYLsYZw14vwIKEqO94G3jxpvlxjyY6BRFu/c8aEIjx C8hBLhVDkZMS9NlMg0CApZhjiQNXYKoB1a3au90sACJ5zKU5m4sTxPJ8odECfxG18YOClczPQgwq7 YrVXucZzw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLpb7-0006Mf-DW; Wed, 01 May 2019 13:48:33 +0000 Date: Wed, 1 May 2019 06:48:33 -0700 From: Christoph Hellwig To: David Kozub Cc: Jens Axboe , Jonathan Derrick , Scott Bauer , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Subject: Re: [PATCH 2/3] block: sed-opal: ioctl for writing to shadow mbr Message-ID: <20190501134833.GB24132@infradead.org> References: <1556666459-17948-1-git-send-email-zub@linux.fjfi.cvut.cz> <1556666459-17948-3-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556666459-17948-3-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (!access_ok((void __user *)(uintptr_t)info->data, info->size)) > + return -EFAULT; Just let the copy_from_user itself return the error itself.