Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965147AbVKHNUQ (ORCPT ); Tue, 8 Nov 2005 08:20:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965160AbVKHNUQ (ORCPT ); Tue, 8 Nov 2005 08:20:16 -0500 Received: from cantor.suse.de ([195.135.220.2]:43171 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S965147AbVKHNUO (ORCPT ); Tue, 8 Nov 2005 08:20:14 -0500 Date: Tue, 08 Nov 2005 14:20:12 +0100 Message-ID: From: Takashi Iwai To: R C Cc: mchehab@brturbo.com.br, linux-kernel@vger.kernel.org, akpm@osdl.org, video4linux-list@redhat.com, rlrevell@joe-job.com, alsa-devel@lists.sourceforge.net, nshmyrev@yandex.ru Subject: Re: [Patch 1/1] V4L (926) Saa7134 alsa can only be autoloaded after saa7134 is active In-Reply-To: <1131451671.2863.4.camel@frolic> References: <1131397121.6632.127.camel@localhost> <1131451671.2863.4.camel@frolic> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta18) (chestnut) (+CVS-20041021) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 695 Lines: 24 At Tue, 08 Nov 2005 12:07:50 +0000, R C wrote: > > On Tue, 2005-11-08 at 12:36 +0100, Takashi Iwai wrote: > [...] > > > Note that "goto done" may > > require the lock again. Also, the succeeding saa7134_dma_stop() is > > superfluous. > > > > No, it's not. dma_stop also affects the main saa7134 module, and it's > needed there. But saa7134_dma_stop() should be already called in trigger callback, which is called via snd_pcm_stop(). Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/