Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: perf build broken in 5.1-rc7
To:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
CC:     Song Liu <liu.song.a23@gmail.com>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>
References: <560abacf-da1d-7f55-755c-2086096bdf2c@mageia.org>
 <fff8c124-505c-91b7-ff4b-cabca894b689@mageia.org>
 <CAPhsuW7dS9TXOAW--U2q9-zmsgS4_K+uZYLnbPra+r+2LjJKDQ@mail.gmail.com>
 <b773df70-58e6-69f8-d566-282b0f7ae579@mageia.org>
 <20190501130751.GB21436@kernel.org>
 <932c4e06-c4db-7bb8-769d-75651d092450@mageia.org>
 <20190501173158.GC21436@kernel.org>
From:   Thomas Backlund <tmb@mageia.org>
Message-ID: <f9439dd5-009b-8930-f233-6826c7e7c076@mageia.org>
Date:   Wed, 1 May 2019 23:20:02 +0300
MIME-Version: 1.0
In-Reply-To: <20190501173158.GC21436@kernel.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Den 01-05-2019 kl. 20:31, skrev Arnaldo Carvalho de Melo:
> Em Wed, May 01, 2019 at 05:09:59PM +0300, Thomas Backlund escreveu:
>> Den 01-05-2019 kl. 16:07, skrev Arnaldo Carvalho de Melo:
>>> Em Tue, Apr 30, 2019 at 04:31:14PM +0300, Thomas Backlund escreveu:
>>> Can you check the output for
>>> /tmp/build/perf/feature/test-disassembler-four-args.make.output in your
>>> system? And also check what is the prototype for the disassembler()
>>> routine on mageia7?
>> I guess this is what fails the test:
>   
>> cat /tmp/build/perf/feature/test-disassembler-four-args.make.output
>> /usr/bin/ld: /usr/lib64/libbfd.a(plugin.o): in function `try_load_plugin':
>> /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:243:
>> undefined reference to `dlopen'
>> /usr/bin/ld:
>> /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:271:
>> undefined reference to `dlsym'
>> /usr/bin/ld:
>> /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:256:
>> undefined reference to `dlclose'
>> /usr/bin/ld:
>> /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:246:
>> undefined reference to `dlerror'
>   
>> as we allow dynamic linking and loading
>   
>> And we use linker flags:
>   
>> rpm --eval %ldflags
>>  ?-Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -Wl,-O1 -Wl,--build-id
>> -Wl,--enable-new-dtags
> Would this help?
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index fe3f97e342fa..6d65874e16c3 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -227,7 +227,7 @@ FEATURE_CHECK_LDFLAGS-libpython-version := $(PYTHON_EMBED_LDOPTS)
>   
>   EATURE_CHECK_LDFLAGS-libaio = -lrt
>   
> -FEATURE_CHECK_LDFLAGS-disassembler-four-args = -lbfd -lopcodes
> +FEATURE_CHECK_LDFLAGS-disassembler-four-args = -lbfd -lopcodes -ldl
>   
>   CFLAGS += -fno-omit-frame-pointer
>   CFLAGS += -ggdb3
>

Yeah, that fixes it

and /tmp/build/perf/feature/test-disassembler-four-args.make.output is now empty as wanted.


So I guess:

Reported-by: Thomas Backlund <tmb@mageia.org>

Tested-by: Thomas Backlund <tmb@mageia.org>


Thanks!


--

Thomas