Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6495473yba; Wed, 1 May 2019 13:31:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzLYuRC5lSHEFs5fDXHEbkx2vrw3MJoCxu2Ao1YwXs+8kTX+/tn0H1r/wpOSowy715TptVK X-Received: by 2002:a63:f115:: with SMTP id f21mr6222pgi.65.1556742707921; Wed, 01 May 2019 13:31:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556742707; cv=none; d=google.com; s=arc-20160816; b=FL0ZxOIBSLrP7gZp83JxlpGLVdCWC1fHKjlPMZfbVUUlllb18wDWpevZJV3u4BK+so mIjXHinHm7Va47hAe1USGWqaNWdUb1JEMy+fqVdCAy4R+nW5I4tS3a1ErbNlwoJ6ZdHY lSBMOuGUQmaKstHcuDXggZ3+8pW5HPEbxLAvY9fSR+KxE5Ppp/475052pGvR68y8JXpH YWw1cuDSE4ru/mDqNgjEeSLxl8vQWZN1vOgXtLDNDtYZO8Mf/ZTYYcMx9gGsfKifxis0 +PSWCHAXce7dZX57E0DpVCL8GEw9XM53LO7v/YWxjxwLbmGxpxPaKKY6fF+xkHk0OYec 2FqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OX6sjbOWFLnIxaPa8t5912cAm1U32qUA0QoGbsbAcHo=; b=Eo47PHrT2lV955qmBY89rne44BJOKQgbE8nCyYC2KHeM4co8/UpHRXgKsrZzMutGAT ySRMgWI7l5Wtn7ukKhbqcvBroxC4Cf3bIyoFQ/eocxC0nuyx8F1ayOO4YaycX84G7ym8 j/v/m+MGrwR4t9iJlhWBd0Aw/dca8oeUzCkmRsHiWxSM10BMWDvuTDvjFQfBQ6SoFla2 d8jqLO2bYCCZJPbePHtmgN9XyZPgoBGEVD44UOp8fAUhGmQj8/KNh4yYlv0ZU8uMnOI4 DZp5q5bK89mkUNji5pLFKkGWJuz7jBXB8MLbmy772rC463RU0+S0jITG05Wjw6373P9Y 5+Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b="HuQyza/s"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j11si27947805pgp.433.2019.05.01.13.31.27; Wed, 01 May 2019 13:31:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b="HuQyza/s"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726327AbfEAU3F (ORCPT + 99 others); Wed, 1 May 2019 16:29:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51505 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbfEAU3F (ORCPT ); Wed, 1 May 2019 16:29:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OX6sjbOWFLnIxaPa8t5912cAm1U32qUA0QoGbsbAcHo=; b=HuQyza/sC87VffW8Ph6TREaVuV tjJWjHh1O/uJt+O3jmx5+wUO6lSjS/Yzmvti8L0LbQGmAGWnUmTws2oawBgL+MajXaalOgTA+6nNr 96QUs+uzrB2w1nmVib21Q7GEmrbkgj6jxf7JrRmcBJOGApUQoWecXjUjXqKkv8ChMb+M=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hLvqf-0008LN-3A; Wed, 01 May 2019 22:29:01 +0200 Date: Wed, 1 May 2019 22:29:01 +0200 From: Andrew Lunn To: Rasmus Villemoes Cc: Vivien Didelot , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Florian Fainelli , Rasmus Villemoes Subject: Re: [RFC PATCH 5/5] net: dsa: add support for mv88e6250 Message-ID: <20190501202901.GF19809@lunn.ch> References: <20190501193126.19196-1-rasmus.villemoes@prevas.dk> <20190501193126.19196-6-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190501193126.19196-6-rasmus.villemoes@prevas.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +++ b/drivers/net/dsa/mv88e6xxx/global1.c > @@ -205,6 +205,26 @@ int mv88e6352_g1_reset(struct mv88e6xxx_chip *chip) > return mv88e6352_g1_wait_ppu_polling(chip); > } > > +/* copy of mv88e6352_g1_reset, without tailcall of mv88e6352_g1_wait_ppu_polling. */ Nit: No need to have this comment. Otherwise Reviewed-by: Andrew Lunn Andrew