Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vineet Gupta <Vineet.Gupta1@synopsys.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>
CC:     Rich Felker <dalias@libc.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        "Namhyung Kim" <namhyung@kernel.org>,
        arcml <linux-snps-arc@lists.infradead.org>
Subject: Re: perf tools build broken after v5.1-rc1
Thread-Topic: perf tools build broken after v5.1-rc1
Thread-Index: AQHU9whSYuAYlq2eD0OAivz0M0d5Nw==
Date:   Wed, 1 May 2019 21:17:52 +0000
Message-ID: <C2D7FE5348E1B147BCA15975FBA2307501A2506BF3@us01wembx1.internal.synopsys.com>
References: <eeb83498-f37f-e234-4941-2731b81dc78c@synopsys.com>
 <20190422152027.GB11750@kernel.org>
 <C2D7FE5348E1B147BCA15975FBA2307501A250584C@us01wembx1.internal.synopsys.com>
 <CAK8P3a2JrAApXDws+t=q8AnKFkHJZSox7gsgwW-xEJTfs_mdzw@mail.gmail.com>
 <20190501204115.GF21436@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/1/19 1:41 PM, Arnaldo Carvalho de Melo wrote:=0A=
>> The 1a787fc5ba18ac7 commit copied over the changes for arm64, but=0A=
>> missed all the other architectures changed in c8ce48f06503 and the=0A=
>> related commits.=0A=
> Right, I have a patch copying the missing headers, and that fixed the=0A=
> build with the glibc-based toolchain, but then broke the uCLibc one :-\=
=0A=
=0A=
tools/perf/util/cloexec.c  #includes <sys/syscall.h> which for glibc includ=
es=0A=
asm/unistd.h=0A=
=0A=
uClibc <sys/syscall.h> OTOH #include <bits/sysnum.h> containign#define __NR=
_*=0A=
(generated by parsing kernel's unistd). This header does the right thing by=
=0A=
chekcing for redefs, but in the end we still collide with newly added=0A=
tools/arc/arc/*/**/unistd.h which doesn't have conditional definitions. I'm=
 sure=0A=
this is not an ARC problem, any uClibc build would be affected. Do you have=
 a arm=0A=
uclibc toolchain to test ?=0A=
=0A=
All in all this is a mess. The quick band aid I can think of would be to ad=
d a=0A=
#ifndef __UCLIBC__ in tools/arch/arc/include/uapi/asm/unistd.h which is sup=
er=0A=
ugly, but in the end the solution is to get rid of this header duplicity.=
=0A=
=0A=
-Vineet=0A=