Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6733519yba; Wed, 1 May 2019 19:19:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLyEGB1vAEgYmPZcc2rRQSGX/6gCokmw/dNamOe8+6dhjJHwPLhlAaxMhmRSvMKozQmmLo X-Received: by 2002:a63:4c1a:: with SMTP id z26mr1272688pga.324.1556763574495; Wed, 01 May 2019 19:19:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556763574; cv=none; d=google.com; s=arc-20160816; b=hWnpgBXCW+RuLWYfXWdk/0addtSIpVBgRiEqbhleQyyVsrTfXuiJQ97S3fkYOVKbew i55alz2q3K7RIHvqLAgdfgtQY719LaTiCJDiEztdwoAuhrCqG2es/rhKywypvBPGPQ6A wMseyazpnvM/nTXCgjwh6u5CQ7+SA74ZBoitb+ycDQK7psIBplkDqgl4jxWp0an1j/58 8Kxc2g2O6J2VeSAPHZeCCVbfhhetBtksfu+DtT73jXUzUapcdkOICnShVRqm22rAzGmi R62aW8EG7nAHL+IGmNmhmEWGA0RHITkvxoLji+61xK5p61bShRDxpDOfcb2wDCJXRsDg +P1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=tSRP9AREY1phAztSLdhpxjCCxjAVr/6vVxlS8p739D8=; b=x8PtXgheLSNtf12qt5hDJCsXpswsfVQX5e0EfzkjJ5PjF2I6QwOB5B79puVFy8wL19 TE+0NgH1vJLzp7QjY//dt8o3fDjb207v3y375K9pijzKbHO2w6JO81MeiGSpkth8r6K4 9HFBqYn9rYmKeJl5DWE+spIVrQBExWa3NpQ5KRWwAnxEn5Qk5LyENq6+VCSzn2DyzeZ/ eSlZjU4jpme0zirP6u92DWQxwr6hZzHlK+7lRxMH3Tkog3ZHYulwJFqUqiLR8lR0RMzZ KswjOthoBcHAKIHUChLwiMV4YKlCciJETD+PwiosNu7G4uMidTaiyLvUYi0lJ1jVhsJl HUvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ulRALQv+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2si22684674pgp.564.2019.05.01.19.19.16; Wed, 01 May 2019 19:19:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ulRALQv+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfEBCST (ORCPT + 99 others); Wed, 1 May 2019 22:18:19 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:54866 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726152AbfEBCST (ORCPT ); Wed, 1 May 2019 22:18:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=tSRP9AREY1phAztSLdhpxjCCxjAVr/6vVxlS8p739D8=; b=ulRALQv+WaEZ dWAzFCLY+CxW6k6PgY3Y8PFjrGSd3H7DCO491Tl3E05IMZiuViUgwAlR4nmwo6GZgtZqKiPUxLFxl uxoNGF6k89EDqMqzlE+I96cwLemX7HXY6YehuuhQdwAKu6kauZrd3N6VoGnzGwnKyhG9dze4qa13Y 5CEiU=; Received: from [211.55.52.15] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hM1IV-0005ps-20; Thu, 02 May 2019 02:18:07 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 0F5F9441D41; Thu, 2 May 2019 03:18:03 +0100 (BST) From: Mark Brown To: Wei Yongjun Cc: alsa-devel@alsa-project.org, Baolin Wang , Chunyan Zhang , Jaroslav Kysela , kernel-janitors@vger.kernel.org, Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Orson Zhai , Takashi Iwai Subject: Applied "ASoC: sprd: Fix return value check in sprd_mcdt_probe()" to the asoc tree In-Reply-To: <20190429122512.59242-1-weiyongjun1@huawei.com> X-Patchwork-Hint: ignore Message-Id: <20190502021803.0F5F9441D41@finisterre.ee.mobilebroadband> Date: Thu, 2 May 2019 03:18:02 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: sprd: Fix return value check in sprd_mcdt_probe() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 7c88b92816dfe5eab224b96577b50ac00b4be68a Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Mon, 29 Apr 2019 12:25:12 +0000 Subject: [PATCH] ASoC: sprd: Fix return value check in sprd_mcdt_probe() In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d7bff893e04f ("ASoC: sprd: Add Spreadtrum multi-channel data transfer support") Signed-off-by: Wei Yongjun Reviewed-by: Baolin Wang Signed-off-by: Mark Brown --- sound/soc/sprd/sprd-mcdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sprd/sprd-mcdt.c b/sound/soc/sprd/sprd-mcdt.c index 28f5e649733d..e9318d7a4810 100644 --- a/sound/soc/sprd/sprd-mcdt.c +++ b/sound/soc/sprd/sprd-mcdt.c @@ -951,8 +951,8 @@ static int sprd_mcdt_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); mcdt->base = devm_ioremap_resource(&pdev->dev, res); - if (!mcdt->base) - return -ENOMEM; + if (IS_ERR(mcdt->base)) + return PTR_ERR(mcdt->base); mcdt->dev = &pdev->dev; spin_lock_init(&mcdt->lock); -- 2.20.1