Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6734840yba; Wed, 1 May 2019 19:21:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqw80ECbIm0SMy3Graax7h6NQbE8c8+k1aDbBy7MwD9rp4qswHrMPbXjORu8sKIZqdvc8XJm X-Received: by 2002:a63:87c6:: with SMTP id i189mr1188793pge.367.1556763710689; Wed, 01 May 2019 19:21:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556763710; cv=none; d=google.com; s=arc-20160816; b=leE8G1tHhUOZjasec7DxVzFvjCwbip+4J3+dZzGYKNNlqB1YUmX34aarOoG6cw2FHs PSsXi43YA788TYaGK7o/kB+1XEoOH2xrSNRe+kQE3Rx7pSav/pFNWInLJeyTHbcPMzIM A2aH8XsEoDPZxKJ7gqj9tZ7Is/4GMn3/+8zIQDDdEsIB1M4fmU19peXiVFOD1tgmtE3t dREwSGJA9E6R5GOuQ6wECx4Ti3HutlHGZkTaeX9Zo+r7Sj6s8bztJc2Qu5i8f5Bkbro2 bxH+Io5ZMj3+A77jRdlxvm2vtgHJb0Gxm2HVfNVSkDPx2mu+AFQQd1f0+WSJwxSeMy3j MYdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=kubXXWC5hG9Tf1ZSHpSxNXJFgzmFjFMboy4IdHsOOYE=; b=Z1bd8xHRKsPVHLASdIB/7UR9h5ADRgs/+SMcucQmrUbbZTHcqfEauMgXRIuNx6CSVN y7McBdaFIaLgihcY0rWoHgY/wxoTOQmLpj1EM/xcmSevGS/XwBIONgtt+ywbtg1QrUDf xNFVVvFx+9plsjsEUjJFgE5kfQeFfKKBX49o1D94QCtS0gHGkjFUveFgv2AKQBHSH+h2 wXglCCuDoMJfEx4mwlWTXMkSr/+yjaB1oHJBd2E6kD9fzDtGzAsn5h5RTRNxPvLeRwsR Zyk8Iedld9W+SDLslL8fz5nkpSb6FIPivV4+ltc5W0/UJw/O1MtgMWSRJc+ouWRywZd9 9ykg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Eu4Z2dQK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6si35128125pgq.127.2019.05.01.19.21.36; Wed, 01 May 2019 19:21:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Eu4Z2dQK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfEBCUN (ORCPT + 99 others); Wed, 1 May 2019 22:20:13 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:56770 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726601AbfEBCTK (ORCPT ); Wed, 1 May 2019 22:19:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=kubXXWC5hG9Tf1ZSHpSxNXJFgzmFjFMboy4IdHsOOYE=; b=Eu4Z2dQK2d5s 7+OPZea8vdm5txFIQ3PXmk2cFESM+o/bLD/y0Y2GZ4yWVnh+BCMG2J8wGq1+nK+v81wtpJ3It4n2g ZU8rdxq++CEIysOxPTqpcdvevSj9kMWV8xpzeW2IGFs6OzMwMpzesxpa9y9EqvusxgkcJEIaIwVa/ jR7wU=; Received: from [211.55.52.15] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hM1JQ-0005va-TA; Thu, 02 May 2019 02:19:05 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 7345A441D56; Thu, 2 May 2019 03:19:01 +0100 (BST) From: Mark Brown To: Fabien Dessenne Cc: Alexandre Torgue , Christophe KERELLO , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Ludovic Barre , Mark Brown , Maxime Coquelin Subject: Applied "spi: stm32-qspi: manage the get_irq error case" to the spi tree In-Reply-To: <1556119140-3319-1-git-send-email-fabien.dessenne@st.com> X-Patchwork-Hint: ignore Message-Id: <20190502021901.7345A441D56@finisterre.ee.mobilebroadband> Date: Thu, 2 May 2019 03:19:01 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: stm32-qspi: manage the get_irq error case has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 4b562de4e227dbc2267c367b0a1ec83051c364f6 Mon Sep 17 00:00:00 2001 From: Fabien Dessenne Date: Wed, 24 Apr 2019 17:19:00 +0200 Subject: [PATCH] spi: stm32-qspi: manage the get_irq error case During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne Acked-by: Ludovic Barre Signed-off-by: Mark Brown --- drivers/spi/spi-stm32-qspi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 11a89aa15d56..42f8e3c6aa1f 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) { + if (irq != -EPROBE_DEFER) + dev_err(dev, "IRQ error missing or invalid\n"); + return irq; + } + ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0, dev_name(dev), qspi); if (ret) { -- 2.20.1