Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: TMoFwjRA8pYF1rDBStDY7lZeYT4oM/8ZnHkGglL0g/mFk2gXVsV+EeK4JQkHghG9sVlkPmqlGp
 CN4w2f23T66F6eNVclj3fybhYgoAxIlLg76JzyyPfJSu46yZtFLtifV93FhrWtyQFBXNgY0whU
 +40xGEI9ueSCVaZnsRJI9Zc7wth0gNlgdPdPWzAL15EuLoTbZ2HaRvUZeHH2ePBZyz+9Vu+dm4
 uJoBk2KZu8sNDxTCI2BPgyp8hjXvO3U+oSAVCH01Y+8vCrz17T8ebf3sCWaBHG9gHOH5qNdA6o
 LxY=
Subject: Re: [PATCH 2/3] usb: usb251xb: Create a ports field collector method
To:     Serge Semin <fancer.lancer@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Serge Semin <Sergey.Semin@t-platforms.ru>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20190424211208.17499-1-fancer.lancer@gmail.com>
 <20190424211208.17499-3-fancer.lancer@gmail.com>
From:   Richard Leitner <richard.leitner@skidata.com>
Message-ID: <9d8fddf3-52aa-f20f-e19c-a53f863cd3ef@skidata.com>
Date:   Thu, 2 May 2019 07:42:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190424211208.17499-3-fancer.lancer@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 24/04/2019 23:12, Serge Semin wrote:
> Seeing the ports field collection functionality is used four times per
> just one function, it's better to have a dedicated method performing
> the task. Note that this fix filters the port 0 out from the lanes
> swapping property the same way as it has been programmed for the rest
> multi-ports properties. But unlike the rest of ports config registers
> the BIT(0) of the Port Lanes Swap register refers to the Upstream Port
> lanes inversion. This fact hasn't been documented in the driver bindings
> nor there were any mentioning about port 0 being treated as upstream
> port. Lets then leave this fix as is for the properties unification
> and create an additional "swap-us-lanes" in the next patch.
> 
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> ---
>   drivers/usb/misc/usb251xb.c | 71 ++++++++++++++-----------------------
>   1 file changed, 26 insertions(+), 45 deletions(-)
> 

Acked-by: Richard Leitner <richard.leitner@skidata.com>