Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6915471yba; Thu, 2 May 2019 00:16:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBwmnI0FTYe5y6O0k5HUjtEeLDhQPK+jZSCqdWVx2WnILQqrYO81AE9f7ItXk1foVOtBzS X-Received: by 2002:a63:560d:: with SMTP id k13mr2419236pgb.124.1556781369187; Thu, 02 May 2019 00:16:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556781369; cv=none; d=google.com; s=arc-20160816; b=Axgz+PM0fou7DX8GTF7/stz2ICXCvvt1tW7KBYUPlGkDnIblIKHXJt3hQsBsUXC6ig D5OLbOl8kaGQVkMqKT0suOqu03wmB2UzzW9hz5V+sk2R7f2hOIOQy1ARs7evn5yQZ9+u URpEDZVQ1ioOJHnhjMvkRLVxv5PFP5ErrnFaZu6Ni1G0MicKkXZBw7M83ogNVQFk7f0E RYwoQnsL0FV248K/s5EXgkLbvoJ8BSiQon0tMH8ZT3iB4mGWYqKeT9f6af/JD9ZrX9le 91gPt3w9Jwx2YOaNkpkCjcq8J5Y5RR9Az8mE0P49ELDzfaa9wyCHEEiEp7819N/I1fuZ pAIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=0j/hy+dXgc/RAD1S28k76wVU38bkzXROFiJee/uy828=; b=wTE3+ieczIQ4p4EOS+0vmlnly6/6szfj4h0tMR+Pp3eno/9hJ/Zo5fPPI/nbh0Mt+k O31Kt2bYi9mgAaXy+YO8IND2bV5XHVKGYuJPI1O9jy3sm7dIWtCGhVpAn6hmqI4WPsYz QJ3bNehxSxCamsdUTuNI4SeUjMYmcWR5yQadFpeh2rAH/GkMjnVQbGonI9kHjw8fdTrp jPnfZIUnKKCJLLI/S9LaUZuhYG5x/6FOX5G0gu1Cqlv/DlBcTIp8RM/TYpn4fgIOZZ7S avKiDEk+7mIHGWmAixVUrj8HXf+KhsTAz0hBnlZ+T5BGRXYaaEqmHnjQFi27/NUgnhz1 HpVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cw7o1hcl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m6si25801264pll.96.2019.05.02.00.15.54; Thu, 02 May 2019 00:16:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cw7o1hcl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbfEBHPD (ORCPT + 99 others); Thu, 2 May 2019 03:15:03 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:46544 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbfEBHPC (ORCPT ); Thu, 2 May 2019 03:15:02 -0400 Received: by mail-io1-f66.google.com with SMTP id m14so1159427ion.13 for ; Thu, 02 May 2019 00:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0j/hy+dXgc/RAD1S28k76wVU38bkzXROFiJee/uy828=; b=cw7o1hclMVDYD/mFSXXORj8k6owJ56onVZPfH09xygF9uxK4qjYMP+dvtxhcH8xSVX unyG8nRFxcr+vKPkF0aqwp2FJ6t44k02rHFxIP+3FZID4voAH48LxjsffUcNfI48hlpj BQg/QNZnuXxe64Uy2niIYoZzJcqprwnFK7Yuy3zilrCeV1kZ4m9oX3GRQ9kCnwpgy4W2 JXTyOvMsSYAwZF/xGCUjdWF/2z6GsXLBZMuWpHsx2EaYhZC0qLPwvipUzFrBHsxhU8Pi awPEKVdHmGODJf6c0uVZCgrNapYJCSfmu/I5c13IkBxSvbyGyEoMguLbtWCYdtlebfxi CZBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0j/hy+dXgc/RAD1S28k76wVU38bkzXROFiJee/uy828=; b=UJhk/oHwAu2Asj4nACvjUsOZPhFq2fDqlnPF8F/wbqUDTKPeL0dix7OVh87iuu7jzA CtP0vz+JZQm7/kniibd1vvY/zo3irmcUW28mapSN7KVTSjydUpjkD5P3Edychl2mK3s3 wUCwwCqEbBteNJhc4mc/ZhFoBz5FgaVtTzdobpxXLy4ENhKuTwh8vbBFkKIAX8ktKMvr 6fMGe42HYHkkqkGIvhFZ6rEAog3K6sqSo/oLCMDYZQpgb/dfehJj9xTo/njJIAnfISq3 ALB1Rjkg0X+UCk1DfamdAgmewx7MUGhv/1+ukJrI+EY+4nT7sbY0CcwqxwfgM6sNQlWI GMVQ== X-Gm-Message-State: APjAAAUs46AiORmNRJ8GO5tch6cZhk6Y1dpdLcrqXyyawZ1Khb9CA0Us oFF26vhsf14Nc+lmP3jfwCP4k4ERrXy+iFWDNuULbg== X-Received: by 2002:a6b:7b47:: with SMTP id m7mr1443589iop.173.1556781301704; Thu, 02 May 2019 00:15:01 -0700 (PDT) MIME-Version: 1.0 References: <20190227202658.197113-1-matthewgarrett@google.com> <20190227202658.197113-3-matthewgarrett@google.com> In-Reply-To: From: Ard Biesheuvel Date: Thu, 2 May 2019 09:14:49 +0200 Message-ID: Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table To: Matthew Garrett , Jarkko Sakkinen , Ingo Molnar Cc: Bartosz Szczepanek , linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?UTF-8?Q?Thi=C3=A9baud_Weksteen?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (+ Ingo) On Tue, 30 Apr 2019 at 21:52, Matthew Garrett wrote: > > On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek wrote: > > > > I may be a little late with this comment, but I've just tested these > > patches on aarch64 platform (from the top of jjs/master) and got > > kernel panic ("Unable to handle kernel read", full log at the end of > > mail). I think there's problem with below call to > > tpm2_calc_event_log_size(), where physical address of efi.tpm_log is > > passed as (void *) and never remapped: > > Yes, it looks like this is just broken. Can you try with the attached patch? I'm a bit uncomfortable with EFI code that is obviously broken and untested being queued for the next merge window in another tree. What is currently queued there? Can we revert this change for the time being, and resubmit it via the EFI tree for v5.3?