Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp7070318yba; Thu, 2 May 2019 03:47:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxxJ3MbWaDZHRcY7kwugUHWIt9r1rRKLm7u9bJzmRkN0TALoNxXyjvraySAzNBmuGWrGSyq X-Received: by 2002:a17:902:8ec6:: with SMTP id x6mr2922594plo.123.1556794025256; Thu, 02 May 2019 03:47:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556794025; cv=none; d=google.com; s=arc-20160816; b=HmZtMyG2WJTwsFi46aEU6VcTJ2i9qLaI6qIPLcBjTrGP684dPF5Xm06WbRGOF00RJG US5lZL7SYVcvPo9bT5l0b7uMoakUem1ays4sXCu/sPcPaUlWa3rd0e/30KOFOF+YMcUp TzJAeG5nUdlNbfXz4XI4X67MbE3nZvfn3MEssJzcjBV6qSFaJYgxc1NczTDYg0pWA3vk xZFTBbgAExRKHyjQ5ayBJRcNB1XN13Q+sj6EHH+v9xX6G+RVRHsJvpeaMAdJsDAe37h+ A/2CgIrrvwliCa45zkahDv3gkCgaq9qgJCYK+qp20jRoZqtjbipG/r5gD8FXQCyWZpHT brgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:openpgp:from:references:cc:to:subject; bh=fKR+LLeA37MUrFsUupra4kLgWz19SqjeISWAGSLkEAg=; b=C24cTYHnsusWOxb2c3WblzUCmd+w3VZWsjQ+iXEfwCSUsYp3nMTuAjgU+uWkfEsEU7 FZhKopcnRqPXR/+oOZlEQf8yuL4cxujnmL2X/sURoLdzvLm5GjbUx5ZYlF1TyzJeNJvd NF0g3fUYGB0DshtVMW5xrvmCL8RIfEYjKrCikun1wtIQpJiTNYXNo/xwnV6aLpJVNWj1 UyrkejQzGOg8rd/W8hE1UYbOh7BMoGuGgqolocfXd/sNneaSXRCMT0Y9ucyOQsHSS1s9 4mVfnmPWfaK2LG73z2cT3NK+bcZJWFqHuhxEwf2v/Ak73I51BVm1841YbgiCSYTkd/gK f7vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 27si5786967pgu.506.2019.05.02.03.46.49; Thu, 02 May 2019 03:47:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbfEBKpI (ORCPT + 99 others); Thu, 2 May 2019 06:45:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:38788 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726353AbfEBKpI (ORCPT ); Thu, 2 May 2019 06:45:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4ABD8AEF6; Thu, 2 May 2019 10:45:06 +0000 (UTC) Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier To: Greg Kroah-Hartman Cc: Nishad Kamdar , Manivannan Sadhasivam , Michael Turquette , Stephen Boyd , Joe Perches , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org References: <20190501070707.GA5619@nishad> <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> <20190502070746.GA16247@kroah.com> <315de620-b638-aea4-d8d2-e00f5a493625@suse.de> <20190502103848.GA17256@kroah.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: Date: Thu, 2 May 2019 12:45:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190502103848.GA17256@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 02.05.19 um 12:38 schrieb Greg Kroah-Hartman: > On Thu, May 02, 2019 at 12:25:36PM +0200, Andreas Färber wrote: >> Am 02.05.19 um 09:07 schrieb Greg Kroah-Hartman: >>> On Wed, May 01, 2019 at 10:20:44PM +0200, Andreas Färber wrote: >>>> + linux-actions >>>> >>>> Am 01.05.19 um 09:07 schrieb Nishad Kamdar: >>>>> This patch corrects the SPDX License Identifier style >>>>> in header files related to Clock Drivers for Actions Semi Socs. >>>>> For C header files Documentation/process/license-rules.rst >>>>> mandates C-like comments (opposed to C source files where >>>>> C++ style should be used) >>>> [...] >>>>> drivers/clk/actions/owl-common.h | 2 +- >>>>> drivers/clk/actions/owl-composite.h | 2 +- >>>>> drivers/clk/actions/owl-divider.h | 2 +- >>>>> drivers/clk/actions/owl-factor.h | 2 +- >>>>> drivers/clk/actions/owl-fixed-factor.h | 2 +- >>>>> drivers/clk/actions/owl-gate.h | 2 +- >>>>> drivers/clk/actions/owl-mux.h | 2 +- >>>>> drivers/clk/actions/owl-pll.h | 2 +- >>>>> drivers/clk/actions/owl-reset.h | 2 +- >>>>> 9 files changed, 9 insertions(+), 9 deletions(-) >>>> >>>> Where's the practical benefit of this patch? These are all private >>>> headers used from C files, so they can handle C++ comments just fine, >>>> otherwise we would've seen build failures. >>> >>> Please read Documentation/process/license-rules.rst, the section >>> entitled "Style", for what the documented formats are for SPDX lines, >>> depending on the file type. >> >> That does in no way answer my question! You conveniently dropped my >> paragraph indicating that I understand why we would do that for public >> headers in include/, but none of these private headers here are included >> in .lds files. So there really seems to be no benefit of switching from >> one style to another for in-tree code. > > It should answer the question, it was "decreed" that all header files > use /* */, and all C files use // for their SPDX lines, so we documented > it that way. > > Yes, maybe it doesn't make "sense" in that this really is only needed > for headers that get included into asm files, which is why we had to do > it this way, but it's better to be consistant than to have random > breakages at times. > > It's not an issue of public headers at all, sorry. > > Consistency is good, as we can have automatic tools check these types of > things, which is the only way to reliably handle the format of something > that needs to be in every file in a project with 63,100+ different > files. Okay, if it's about consistency then there will be more cases to fix. What about this one: My interpretation of the documentation has been that I should end the comment after the identifiers: /* SPDX-... */ /* ... */ Some people deviate by doing /* SPDX-... * foo */ So the documentation may need to be extended to clarify that for full consistency, as well as clarify the previous scenario: "If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used." To me that reads very different from what you just said above. Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)