Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v1 3/4] powerpc/mm: Move book3s32 specifics in
 subdirectory mm/book3s64
To:     Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>
Cc:     linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
References: <cover.1553853405.git.christophe.leroy@c-s.fr>
 <12c1ba4fc9e2e55ca44c5c57225669b296d48c74.1553853405.git.christophe.leroy@c-s.fr>
 <87tvedxfa6.fsf@concordia.ellerman.id.au>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <9577f0d2-2447-5407-0b69-339a89cf40e1@c-s.fr>
Date:   Thu, 2 May 2019 13:43:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <87tvedxfa6.fsf@concordia.ellerman.id.au>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Le 02/05/2019 à 13:32, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
> 
>> Several files in arch/powerpc/mm are only for book3S32. This patch
>> creates a subdirectory for them.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>>   arch/powerpc/mm/Makefile                            | 3 +--
>>   arch/powerpc/mm/book3s32/Makefile                   | 6 ++++++
>>   arch/powerpc/mm/{ => book3s32}/hash_low_32.S        | 0
>>   arch/powerpc/mm/{ => book3s32}/mmu_context_hash32.c | 0
>>   arch/powerpc/mm/{ => book3s32}/ppc_mmu_32.c         | 0
>>   arch/powerpc/mm/{ => book3s32}/tlb_hash32.c         | 0
>>   6 files changed, 7 insertions(+), 2 deletions(-)
>>   create mode 100644 arch/powerpc/mm/book3s32/Makefile
>>   rename arch/powerpc/mm/{ => book3s32}/hash_low_32.S (100%)
>>   rename arch/powerpc/mm/{ => book3s32}/mmu_context_hash32.c (100%)
>>   rename arch/powerpc/mm/{ => book3s32}/ppc_mmu_32.c (100%)
>>   rename arch/powerpc/mm/{ => book3s32}/tlb_hash32.c (100%)
> 
> I shortened them to:
> 
>    arch/powerpc/mm/{hash_low_32.S => book3s32/hash_low.S}
>    arch/powerpc/mm/{ppc_mmu_32.c => book3s32/mmu.c}

To be consistent with what you did in nohash/ dir, shouldn't we rename 
the above 'ppc.c' or 'ppc_32.c' instead of 'mmu.c' ?

Christophe

>    arch/powerpc/mm/{mmu_context_hash32.c => book3s32/mmu_context.c}
>    arch/powerpc/mm/{tlb_hash32.c => book3s32/tlb.c}
> 
> cheers
>