Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030306AbVKHS7x (ORCPT ); Tue, 8 Nov 2005 13:59:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030310AbVKHS7x (ORCPT ); Tue, 8 Nov 2005 13:59:53 -0500 Received: from omx2-ext.sgi.com ([192.48.171.19]:741 "EHLO omx2.sgi.com") by vger.kernel.org with ESMTP id S1030306AbVKHS7w (ORCPT ); Tue, 8 Nov 2005 13:59:52 -0500 Date: Tue, 8 Nov 2005 10:59:46 -0800 (PST) From: Christoph Lameter To: Pekka J Enberg cc: Matthew Dobson , kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] Inline 3 functions In-Reply-To: Message-ID: References: <436FF51D.8080509@us.ibm.com> <436FF894.8090204@us.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 17 On Tue, 8 Nov 2005, Pekka J Enberg wrote: > On Mon, 7 Nov 2005, Matthew Dobson wrote: > > I found three functions in slab.c that have only 1 caller (kmem_getpages, > > alloc_slabmgmt, and set_slab_attr), so let's inline them. > > Why? They aren't on the hot path and I don't see how this is an > improvement... It avoids the call/return sequences so it may decrease code size a bit and allow the compiler (if its up to the task) to do more CSE optimizations. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/