Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030321AbVKHTJS (ORCPT ); Tue, 8 Nov 2005 14:09:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965267AbVKHTJS (ORCPT ); Tue, 8 Nov 2005 14:09:18 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:30884 "EHLO e2.ny.us.ibm.com") by vger.kernel.org with ESMTP id S965255AbVKHTJR (ORCPT ); Tue, 8 Nov 2005 14:09:17 -0500 Message-ID: <4370F7DA.5000307@us.ibm.com> Date: Tue, 08 Nov 2005 11:09:14 -0800 From: Matthew Dobson User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051011) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Christoph Lameter CC: Alexey Dobriyan , kernel-janitors@lists.osdl.org, Pekka J Enberg , linux-kernel@vger.kernel.org Subject: Re: [KJ] [PATCH 6/8] Cleanup slabinfo_write() References: <436FF51D.8080509@us.ibm.com> <436FF7F7.1060907@us.ibm.com> <20051108105013.GA7678@mipter.zuzino.mipt.ru> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 28 Christoph Lameter wrote: > On Tue, 8 Nov 2005, Alexey Dobriyan wrote: > > >>On Mon, Nov 07, 2005 at 04:57:27PM -0800, Matthew Dobson wrote: >> >>>* Set 'res' at declaration instead of later in the function. >> >>I hate to initialize a varible two miles away from the place where it's >>used. > > > > >>>- int limit, batchcount, shared, res; >>>+ int limit, batchcount, shared, res = -EINVAL; > > > Looks more confusing than before. Fair enough. I'll drop that bit. -Matt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/