Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030334AbVKHTKa (ORCPT ); Tue, 8 Nov 2005 14:10:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030340AbVKHTKa (ORCPT ); Tue, 8 Nov 2005 14:10:30 -0500 Received: from omx3-ext.sgi.com ([192.48.171.20]:45759 "EHLO omx3.sgi.com") by vger.kernel.org with ESMTP id S1030334AbVKHTK3 (ORCPT ); Tue, 8 Nov 2005 14:10:29 -0500 Date: Tue, 8 Nov 2005 11:09:31 -0800 (PST) From: Christoph Lameter To: Matthew Dobson cc: Roland Dreier , kernel-janitors@lists.osdl.org, Pekka J Enberg , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] Cleanup kmem_cache_create() In-Reply-To: <4370F6BB.1070409@us.ibm.com> Message-ID: References: <436FF51D.8080509@us.ibm.com> <436FF70D.6040604@us.ibm.com> <52mzkfrily.fsf@cisco.com> <4370F6BB.1070409@us.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 18 On Tue, 8 Nov 2005, Matthew Dobson wrote: > > A large object in terms of this patch is a object greater than 4096 bytes > > not an object greater than PAGE_SIZE. I think the absolute size is > > desired. > Would you be OK with at least NAMING the constant? I won't name it > PAGE_SIZE (of course), but LARGE_OBJECT_SIZE or something? Ask Manfred about this. I think he coded it that way and he usually has good reasons for it. Thanks for the cleanup work! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/