Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965128AbVKHTVJ (ORCPT ); Tue, 8 Nov 2005 14:21:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965255AbVKHTVI (ORCPT ); Tue, 8 Nov 2005 14:21:08 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:41683 "EHLO e5.ny.us.ibm.com") by vger.kernel.org with ESMTP id S965128AbVKHTVH (ORCPT ); Tue, 8 Nov 2005 14:21:07 -0500 Message-ID: <4370FA9F.6010800@us.ibm.com> Date: Tue, 08 Nov 2005 11:21:03 -0800 From: Matthew Dobson User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051011) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Christoph Lameter CC: Roland Dreier , kernel-janitors@lists.osdl.org, Pekka J Enberg , linux-kernel@vger.kernel.org, manfred@colorfullife.com Subject: Re: [PATCH 4/8] Cleanup kmem_cache_create() References: <436FF51D.8080509@us.ibm.com> <436FF70D.6040604@us.ibm.com> <52mzkfrily.fsf@cisco.com> <4370F6BB.1070409@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 26 Christoph Lameter wrote: > On Tue, 8 Nov 2005, Matthew Dobson wrote: > > >>>A large object in terms of this patch is a object greater than 4096 bytes >>>not an object greater than PAGE_SIZE. I think the absolute size is >>>desired. >> >>Would you be OK with at least NAMING the constant? I won't name it >>PAGE_SIZE (of course), but LARGE_OBJECT_SIZE or something? > > > Ask Manfred about this. I think he coded it that way and he usually has > good reasons for it. > > Thanks for the cleanup work! Manfred, any reason not to name this constant in slab.c? If there's a good reason not to, I'm perfectly happy to leave it alone. :) -Matt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/