Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp7375655yba; Thu, 2 May 2019 08:49:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPrt69iYgHbILsrEua0U6+EX5nDH5q9JYPvY3lXW6bC/1Gn30FLLLG/ywGiy1Le+8hP3o7 X-Received: by 2002:a17:902:28a9:: with SMTP id f38mr4429008plb.295.1556812176095; Thu, 02 May 2019 08:49:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556812176; cv=none; d=google.com; s=arc-20160816; b=v6WEwsqV+vTwWV9JIEgu3O2SZf+69RChJaZP7BaiHxSROMKVmRXxEAE+3uoCRqzvja zHScAz6DDw+5tFa/XrF7zzb9xNfOBhNS6hrMB/PesRffAqe2ZDA3cnQeNT2geWeh3xGS YorpXP3lFnEKOXFCL+IdJ44nABbfzz+HkjKB17x6uPCBqxci8+a70Hm9QAd96bkn6nsL Gsa4t4Cf3Mc3Ai5lgKQB2qGE0KS752fJgkAId3xUbfgSIFGSzCzE6h/gOe98qDl2+qwK qbui5btdyk8J9F0eNv15iyNbGfCe28/cUqxiANqTA4qSsFYtdL7MmO4Qc/scvhRcTF/s vvyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=x9uyOIdDPhJqyhlBftu0fUKr00NWumUqnrc9CAgxWYM=; b=vxixfN5tCinqSHMifUcRwYJ3lc2JF31CBKYusVBBJQVugpgVIPW32rpBCX+tMuTPLl RtAOoQViBzO/+M0/cBSf1IzMI6Nj1i9l5y5lYKsFY4LDsRO0SS0mUS4rZN7p3iRo88cz otYnEJU77IG8U9WouB/wOb0kv6og0DfWtCFCg/UW7eHHCdXxYLWUYkAAuca1jxTV/kcc O1cEk5nd5eYXGEzkzr0FMIPmSyE6PXLqS+H86KC7gKdmwS5CkR7ydBo00RXbzshG2JP+ JS8Ium95hgM2ASeQ2aZfPHKPJSpB7C4IGWRoC11oJEkCaVzv0PAOnqTwkxSDXau4L27e /6mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uyuESeWO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y4si3968221plb.283.2019.05.02.08.49.20; Thu, 02 May 2019 08:49:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uyuESeWO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727372AbfEBPYn (ORCPT + 99 others); Thu, 2 May 2019 11:24:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:40616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727359AbfEBPYl (ORCPT ); Thu, 2 May 2019 11:24:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C1BF208C4; Thu, 2 May 2019 15:24:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556810680; bh=iyutgjCnqeEGMv7+w36WlERhI2JO6mPMmmxKpcNWrkY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uyuESeWOIW6yGNuDEVordRuZVu798HHnKb7ofWLvJp4Bj1fuzU2nrV8c21luA4SyY lK+SqRtZHqeMZEOwpN1D5N1l+v7ddpOkBlyQySRrk/SaUeczlvgI1a230tKzDLh5yG OemVewfdT7OOvFM2d6u9iYT0sgAR1sJyQ29t/U/4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Manish Rangankar , Mukesh Ojha , "Martin K. Petersen" , "Sasha Levin (Microsoft)" Subject: [PATCH 4.14 39/49] scsi: qla4xxx: fix a potential NULL pointer dereference Date: Thu, 2 May 2019 17:21:16 +0200 Message-Id: <20190502143328.907283623@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143323.397051088@linuxfoundation.org> References: <20190502143323.397051088@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6 ] In case iscsi_lookup_endpoint fails, the fix returns -EINVAL to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Acked-by: Manish Rangankar Reviewed-by: Mukesh Ojha Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin (Microsoft) --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 22dc70a2138e..630b7404843d 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -3207,6 +3207,8 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session, if (iscsi_conn_bind(cls_session, cls_conn, is_leading)) return -EINVAL; ep = iscsi_lookup_endpoint(transport_fd); + if (!ep) + return -EINVAL; conn = cls_conn->dd_data; qla_conn = conn->dd_data; qla_conn->qla_ep = ep->dd_data; -- 2.19.1