Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 May 2019 18:03:23 +0200 (CEST)
From:   David Kozub <zub@linux.fjfi.cvut.cz>
To:     Scott Bauer <sbauer@plzdonthack.me>
cc:     Jens Axboe <axboe@kernel.dk>,
        Jonathan Derrick <jonathan.derrick@intel.com>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH 0/3] block: sed-opal: add support for shadow MBR done
 flag and write
In-Reply-To: <20190502123036.GA4657@hacktheplanet>
Message-ID: <alpine.LRH.2.21.1905021749060.929@linux.fjfi.cvut.cz>
References: <1556666459-17948-1-git-send-email-zub@linux.fjfi.cvut.cz> <20190502123036.GA4657@hacktheplanet>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2 May 2019, Scott Bauer wrote:

> On Wed, May 01, 2019 at 01:20:56AM +0200, David Kozub wrote:
>>
>> Jonas Rabenstein (3):
>>   block: sed-opal: add ioctl for done-mark of shadow mbr
>>   block: sed-opal: ioctl for writing to shadow mbr
>>   block: sed-opal: check size of shadow mbr
>>
>>  block/opal_proto.h            |  16 ++++
>>  block/sed-opal.c              | 160 +++++++++++++++++++++++++++++++++-
>>  include/linux/sed-opal.h      |   2 +
>>  include/uapi/linux/sed-opal.h |  20 +++++
>>  4 files changed, 196 insertions(+), 2 deletions(-)
>>
>
> I'll review this over the weekend. Is this essentially the same thing
> we reviewed a month or two ago or are there little differences due to
> it be split across two different series?

The first patch (block: sed-opal: add ioctl for done-mark of shadow mbr) 
is a bit different because a new struct and enum were introduced. The rest 
is pretty much the same. That's also why I kept the reviewd-by tags.

Best regards,
David