Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vineet Gupta <Vineet.Gupta1@synopsys.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
CC:     Arnd Bergmann <arnd@arndb.de>, Rich Felker <dalias@libc.org>,
        "Arnaldo Carvalho de Melo" <acme@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "Jiri Olsa" <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        arcml <linux-snps-arc@lists.infradead.org>
Subject: Re: perf tools build broken after v5.1-rc1
Thread-Topic: perf tools build broken after v5.1-rc1
Thread-Index: AQHU9whSYuAYlq2eD0OAivz0M0d5Nw==
Date:   Thu, 2 May 2019 16:09:43 +0000
Message-ID: <C2D7FE5348E1B147BCA15975FBA2307501A2506D04@us01wembx1.internal.synopsys.com>
References: <eeb83498-f37f-e234-4941-2731b81dc78c@synopsys.com>
 <20190422152027.GB11750@kernel.org>
 <C2D7FE5348E1B147BCA15975FBA2307501A250584C@us01wembx1.internal.synopsys.com>
 <CAK8P3a2JrAApXDws+t=q8AnKFkHJZSox7gsgwW-xEJTfs_mdzw@mail.gmail.com>
 <20190501204115.GF21436@kernel.org>
 <C2D7FE5348E1B147BCA15975FBA2307501A2506BF3@us01wembx1.internal.synopsys.com>
 <20190502143618.GH21436@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/2/19 7:36 AM, Arnaldo Carvalho de Melo wrote:=0A=
> Em Wed, May 01, 2019 at 09:17:52PM +0000, Vineet Gupta escreveu:=0A=
>> On 5/1/19 1:41 PM, Arnaldo Carvalho de Melo wrote:=0A=
>>>> The 1a787fc5ba18ac7 commit copied over the changes for arm64, but=0A=
>>>> missed all the other architectures changed in c8ce48f06503 and the=0A=
>>>> related commits.=0A=
>>> Right, I have a patch copying the missing headers, and that fixed the=
=0A=
>>> build with the glibc-based toolchain, but then broke the uCLibc one :-\=
=0A=
>  =0A=
>> tools/perf/util/cloexec.c  #includes <sys/syscall.h> which for glibc inc=
ludes=0A=
>> asm/unistd.h=0A=
>  =0A=
>> uClibc <sys/syscall.h> OTOH #include <bits/sysnum.h> containign#define _=
_NR_*=0A=
>> (generated by parsing kernel's unistd). This header does the right thing=
 by=0A=
>> chekcing for redefs, but in the end we still collide with newly added=0A=
>> tools/arc/arc/*/**/unistd.h which doesn't have conditional definitions. =
I'm sure=0A=
>> this is not an ARC problem, any uClibc build would be affected. Do you h=
ave a arm=0A=
>> uclibc toolchain to test ?=0A=
> This solves it for fedora:29,=0A=
> arc_gnu_2017.09-rc2_prebuilt_uclibc_le_arc700_linux_install,=0A=
> arc_gnu_2019.03-rc1_prebuilt_uclibc_le_archs_linux_install and=0A=
> arc_gnu_2019.03-rc1_prebuilt_glibc_le_archs_linux_install.=0A=
>=0A=
> Also ok with:=0A=
>=0A=
>   make -C tools/perf build-test=0A=
>=0A=
> Now build testing with the full set of containers.=0A=
>=0A=
> - Arnaldo=0A=
>=0A=
> commit 1931594a680dba28e98b526192dd065430c850c0=0A=
> Author: Arnaldo Carvalho de Melo <acme@redhat.com>=0A=
> Date:   Thu May 2 09:26:23 2019 -0400=0A=
>=0A=
>     perf tools: Remove needless asm/unistd.h include fixing build in some=
 places=0A=
>     =0A=
>     We were including sys/syscall.h and asm/unistd.h, since sys/syscall.h=
=0A=
>     includes asm/unistd.h, sometimes this leads to the redefinition of=0A=
>     defines, breaking the build.=0A=
>     =0A=
>     Noticed on ARC with uCLibc.=0A=
=0A=
Thx for this Arnaldo.=0A=
=0A=
While this takes care of immediate issues, for the long term, are you open =
to idea=0A=
of removing the header duplicity.=0A=
We could use a "less evil" idiom of copying only the minimal bits (since th=
e sync=0A=
onus remains one way or the other)=0A=
e.g. I spotted below in bpf code and also seen in other ah-hoc multi arch p=
rojects=0A=
=0A=
#ifdef __NR_xx=0A=
# if defined (__arch_y__)=0A=
=0A=
# elif defined (__arch_z__)=0A=
=0A=
# endif=0A=
#endif=0A=
=0A=
=0A=