Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <91611b9e159799bbf603b65cf7bb6b37dd81b075.camel@intel.com>
Subject: Re: [PATCH] binfmt_elf: Extract .note.gnu.property from an ELF file
From:   Yu-cheng Yu <yu-cheng.yu@intel.com>
To:     Dave Martin <Dave.Martin@arm.com>
Cc:     x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-mm@kvack.org,
        linux-arch@vger.kernel.org, linux-api@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@amacapital.net>,
        Balbir Singh <bsingharora@gmail.com>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Eugene Syromiatnikov <esyr@redhat.com>,
        Florian Weimer <fweimer@redhat.com>,
        "H.J. Lu" <hjl.tools@gmail.com>, Jann Horn <jannh@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Kees Cook <keescook@chromium.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Oleg Nesterov <oleg@redhat.com>, Pavel Machek <pavel@ucw.cz>,
        Peter Zijlstra <peterz@infradead.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Vedvyas Shanbhogue <vedvyas.shanbhogue@intel.com>,
        Szabolcs Nagy <szabolcs.nagy@arm.com>,
        libc-alpha@sourceware.org
Date:   Thu, 02 May 2019 09:25:56 -0700
In-Reply-To: <20190502161424.GQ3567@e103592.cambridge.arm.com>
References: <20190501211217.5039-1-yu-cheng.yu@intel.com>
         <20190502111003.GO3567@e103592.cambridge.arm.com>
         <5b2c6cee345e00182e97842ae90c02cdcd830135.camel@intel.com>
         <20190502161424.GQ3567@e103592.cambridge.arm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-05-02 at 17:14 +0100, Dave Martin wrote:
> On Thu, May 02, 2019 at 08:47:06AM -0700, Yu-cheng Yu wrote:
> > On Thu, 2019-05-02 at 12:10 +0100, Dave Martin wrote:
> > > On Wed, May 01, 2019 at 02:12:17PM -0700, Yu-cheng Yu wrote:
> > > > An ELF file's .note.gnu.property indicates features the executable file
> > > > can support.  For example, the property GNU_PROPERTY_X86_FEATURE_1_AND
> > > > indicates the file supports GNU_PROPERTY_X86_FEATURE_1_IBT and/or
> > > > GNU_PROPERTY_X86_FEATURE_1_SHSTK.
> > 
> > [...]
> > > A couple of questions before I look in more detail:
> > > 
> > > 1) Can we rely on PT_GNU_PROPERTY being present in the phdrs to describe
> > > the NT_GNU_PROPERTY_TYPE_0 note?  If so, we can avoid trying to parse
> > > irrelevant PT_NOTE segments.
> > 
> > Some older linkers can create multiples of NT_GNU_PROPERTY_TYPE_0.  The code
> > scans all PT_NOTE segments to ensure there is only one
> > NT_GNU_PROPERTY_TYPE_0. 
> > If there are multiples, then all are considered invalid.
> 
> I'm concerned that in the arm64 case we would waste some effort by
> scanning multiple notes.
> 
> Could we do something like iterating over the phdrs, and if we find
> exactly one PT_GNU_PROPERTY then use that, else fall back to scanning
> all PT_NOTEs?

That makes sense to me, but the concern is that we don't know the
PT_GNU_PROPERTY the only one.  This probably needs to be discussed with more
people.

> > > 2) Are there standard types for things like the program property header?
> > > If not, can we add something in elf.h?  We should try to coordinate with
> > > libc on that.  Something like
> > > 
> > > typedef __u32 Elf_Word;
> > > 
> > > typedef struct {
> > > 	Elf_Word pr_type;
> > > 	Elf_Word pr_datasz;
> > > } Elf_Gnu_Prophdr;
> > > 
> > > (i.e., just the header part from [1], with a more specific name -- which
> > > I just made up).
> > 
> > Yes, I will fix that.
> > 
> > [...]
> > > 3) It looks like we have to go and re-parse all the notes for every
> > > property requested by the arch code.
> > 
> > As explained above, it is necessary to scan all PT_NOTE segments.  But there
> > should be only one NT_GNU_PROPERTY_TYPE_0 in an ELF file.  Once that is
> > found,
> > perhaps we can store it somewhere, or call into the arch code as you
> > mentioned
> > below.  I will look into that.
> 
> Just to get something working on arm64, I'm working on some hacks that
> move things around a bit -- I'll post when I have something.
> 
> Did you have any view on my other point, below?

That should work.  I will also make some changes for that.

> 
> Cheers
> ---Dave
> 
> > > For now there is only one property requested anyway, so this is probably
> > > not too bad.  But could we flip things around so that we have some
> > > CONFIG_ARCH_WANTS_ELF_GNU_PROPERTY (say), and have the ELF core code
> > > call into the arch backend for each property found?
> > > 
> > > The arch could provide some hook
> > > 
> > > 	int arch_elf_has_gnu_property(const Elf_Gnu_Prophdr *prop,
> > > 					const void *data);
> > > 
> > > to consume the properties as they are found.
> > > 
> > > This would effectively replace the arch_setup_property() hook you
> > > currently have.
> > > 
> > > Cheers
> > > ---Dave
> > > 
> > > [1] https://github.com/hjl-tools/linux-abi/wiki/Linux-Extensions-to-gABI