Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp7510725yba; Thu, 2 May 2019 11:07:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqjP6+vNSEA8YgtcaKzZmmYFwxSEsb2j/Pg++7mmph9Z1MPy8E6ecrQFAV8Ox0/AxriLvP X-Received: by 2002:aa7:8b88:: with SMTP id r8mr5604329pfd.174.1556820444384; Thu, 02 May 2019 11:07:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556820444; cv=none; d=google.com; s=arc-20160816; b=vSS4gF+TjHJmWT3ALpZZ+5jRbIj7Kx1CxddwQ8cPpIArq5xAFbo1HMHMjrIAPee0eh H+lY22ELgtjCNG/e+r1pCIYQcSWHWwT/06jl2uxcMCH0J15poWvrIHc7hXe0JQojIahW 2IOUqsDt45AReBC8YIHWZnq8qzm9P2NBAeXjwXGXJccr4KGTXv5E+dWNs0L5kRcTx1il bbNLxph6uBHLtPhZOGV+L7oX3mPqEKYzm520irh8q+ZdCn6KG/BLYnCAUNDjjupEu7wk suYFNmz2MAOp0zuSTpyQaZPcwa3YtCyC9bKmMUF/NRJQkucUEguxzuY3VnrvrpnzSN+M yNkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=SU8aAABM065YNEdWIrP9VLfp6wM73Cy7sMn9LwYteHs=; b=zCOVc0qG9gqfPcUhxudAV/Du8C+arm+9GwdRdRg9a7XJ9nEkpOnnVsAgQ1YJqBaH/1 npY0BthqeYBGKA/6la9oJeBbu6M+X8HM95mSQ2lE6qvJzD3hfnZf8PNn7k0ZDKAJX7dW 4IMXEG7zJbKeQyxOeropxyj2KrUng9/ye3s2Tmoc6yYyw/T2Kr3w+RnlEcWpYXSkBACQ GALM2QlBKy2n8vwmBg2e2aFtuJt6MVKAWrEoSZIIB/O9D+riqGuJvWgC1q3iLWaU72xW iLu2irjHV+t4Ektgv6yuUht9LiHZXCasZvLf5L3DdtLFyHBHI4eJInfV8zFbyKahsbi6 xuZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=f6K3kASC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g70si29468156pgc.87.2019.05.02.11.07.08; Thu, 02 May 2019 11:07:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=f6K3kASC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbfEBSEQ (ORCPT + 99 others); Thu, 2 May 2019 14:04:16 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:37575 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbfEBSEQ (ORCPT ); Thu, 2 May 2019 14:04:16 -0400 Received: by mail-io1-f67.google.com with SMTP id j14so2482122ioj.4 for ; Thu, 02 May 2019 11:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SU8aAABM065YNEdWIrP9VLfp6wM73Cy7sMn9LwYteHs=; b=f6K3kASCYwWOdpWL00hYEo/+O/+CwPAE2qa1EtzQcxap9LAXrl7bqlrPM0S9hqlXsQ qX1HzZF4jMJasflI6Mybe9MKHpeTHoWe5acw8gOxw8Hf9pIhift/FFiimHgdv2e4xZfb 9kf/xiRQxrC/X8/LFpH6zxYwZ4Wn+mxVYzkhqbPxAfzwgjb60gpIKkR4SlezVynmltla wTVQkENc8evGTLe+QtK8AJopchFw5aKJ7SA+Gf4T3TrKQPeZB9KFLZ+YusbTSKcVvgf+ 8lb7chFVhHZ5bqsR3MBHXCsCgth8bLv9Qb4BtrcxHEASc7H/izDiylpK/cJV/CYmLy8D gDSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SU8aAABM065YNEdWIrP9VLfp6wM73Cy7sMn9LwYteHs=; b=owg2jTcRWYOUy8Ls9Qtlkgig5ne5xHDwE1CdE8v19da4HbV0OBpUaQvQJsWx5F03fh bgtoHuXjz7S9upb9SmEou1JJMop46MRWga94VGd1wY8JqNs1ekHFTFE2DQakQqKbAVx1 6TSxa8rTVEhYsVMeYvV3fHRWPeqr3//UI7AmFrMBP7SPTzB+te4nERKE6rGx/FJdQ7Ce otss7FevKX605CIhFlK4qJ467iYdxy4APeoGBt5G7OwgNH+qTe0bMJA1jInKj6YGmccV J+Lb7aQ0AfFe5rG+wqezf7oevRZ3A+4SmwoAIPYNvPovunTlPbPlfhr2+W3N6ddyRIpg fdvA== X-Gm-Message-State: APjAAAVJ7z33tXt0fRh4s7He/eteVvjE6zQHORFIh5xQhwQ0iEWYu8IH NWqIuYa0ZH2GO5UOJXTHfCbj/13Pf8qOOaucNpfYMA== X-Received: by 2002:a5e:8348:: with SMTP id y8mr3682573iom.88.1556820254756; Thu, 02 May 2019 11:04:14 -0700 (PDT) MIME-Version: 1.0 References: <20190227202658.197113-1-matthewgarrett@google.com> <20190227202658.197113-3-matthewgarrett@google.com> In-Reply-To: From: Matthew Garrett Date: Thu, 2 May 2019 11:04:03 -0700 Message-ID: Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table To: Ard Biesheuvel Cc: Jarkko Sakkinen , Ingo Molnar , Bartosz Szczepanek , linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?UTF-8?Q?Thi=C3=A9baud_Weksteen?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 2, 2019 at 12:15 AM Ard Biesheuvel wrote: > > (+ Ingo) > > On Tue, 30 Apr 2019 at 21:52, Matthew Garrett wrote: > > > > On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek wrote: > > > > > > I may be a little late with this comment, but I've just tested these > > > patches on aarch64 platform (from the top of jjs/master) and got > > > kernel panic ("Unable to handle kernel read", full log at the end of > > > mail). I think there's problem with below call to > > > tpm2_calc_event_log_size(), where physical address of efi.tpm_log is > > > passed as (void *) and never remapped: > > > > Yes, it looks like this is just broken. Can you try with the attached patch? > > I'm a bit uncomfortable with EFI code that is obviously broken and > untested being queued for the next merge window in another tree. The patchset was Cc:ed to linux-efi@. Is there anything else I should have done to ensure you picked it up rather than Jarkko?