Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp7626846yba; Thu, 2 May 2019 13:14:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxHrrlVsArucDV0iEozouul7MzIOvkXY2yik1SXOwWvShQjTx3Vzb5lnic7JJedPamWHYa X-Received: by 2002:a63:c104:: with SMTP id w4mr5851510pgf.409.1556828061570; Thu, 02 May 2019 13:14:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556828061; cv=none; d=google.com; s=arc-20160816; b=ELIcY6lTcNfsc4Bw2y3SfvIClLWYBFU5BovdCRjy2oDe5QyhefrcmXTLDFMzoEIo6P K1HV5/bE5GrbOQlC8L4jBHKInODe+kSHOhKEQXJJ+oUEeujxG7fiuC1lbtsq5fe0c7ZX FwZvbgYNmgpFUADy6e32GM645q7CDezrp8JXogJ2qbtcXaEmRU+O2GLTZXv9uF8Mi1HF aL1z6f7f2e1BDUaT1B4UoJuZiX7jGZ/iwzKBV/jtlOkEbB/1tg8qQHwNYH6NLs0cbfwl OgXEMvgK1bX4s1wWxEKkN6/jAj7bkemwwqic6Zf5AEbWcBLw8OF5BcykiVdaAseZLbwh 5Bmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=pvckd5liEsMXk3SQVRYFMm9nVV/fz8aPm/503hwbENU=; b=twMkY0NN/kL78Adyr5Vy9hm5+A5o+cbT3ZYmN9ZLUXxddQbYkpJn//IVvs+YGp+tXb 0I5LCX3wWR69UagNI1I1TfCK6baBNaqc6QJFHoEGcP6A2h7g73f5WITXT2UKJFL25ibD AlKuComdlxaAILbEcAJnJL7YkT1IRSC4ettpzIbN1mcF89ZPuYZYDRYKU1JPP0Zds9ee 8FmNbn5iHbGQC23vzC4zvr5v/VwXju2kU5ALPqzK/4u0oNFLGuAP+4ScqIetSyc5MaLA SXAGuMGsDu5viU6pEpnJ4U/5OFAP0jKnDsUj0z7772WA4+EM1gp7V9DtoV0QuWRJ0Ftp mYjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=P+qLA+Jt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r16si23925pgv.503.2019.05.02.13.14.05; Thu, 02 May 2019 13:14:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=P+qLA+Jt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726193AbfEBULz (ORCPT + 99 others); Thu, 2 May 2019 16:11:55 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:33499 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbfEBULz (ORCPT ); Thu, 2 May 2019 16:11:55 -0400 Received: by mail-it1-f195.google.com with SMTP id u16so1526215itc.0 for ; Thu, 02 May 2019 13:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pvckd5liEsMXk3SQVRYFMm9nVV/fz8aPm/503hwbENU=; b=P+qLA+JtbrZ4IvqT2Nw2c/DtVkzUL1OcnjW0iN7JmQ7Z8147Jl2nSlIzHYDiHFa/bQ h60Aa/b1WHs3ul7uheOfeXezQ0qcZJXf4fgM2tgARC9sL3u04KUlSKuHE7uBNO1yM4/C hefB6NQSteaZMKRL46INLlIeSRAfHTu6jXWhdv1/LULsxInBLz6Pz9giPbiqQYa0UWfb eueS0ut/cEebX2Le4Yrh4AqN4JWMsie82t10EvC93P8ftA0hQ6s8iExeK9/z+QMFIhGt OZnL5FApelucM5AKiN+hpnX+Vlz9xUTpnV4+iXTnjt4JrxtjJbky5vyd3r7Bbrb8Z3i0 ARXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pvckd5liEsMXk3SQVRYFMm9nVV/fz8aPm/503hwbENU=; b=oOvxMfNq+sowBNKf2sbZagcqyj5qoBKo2VVUVYZfRUyilVxyIiI1oSMSRPvLnocqGW +RpWff4jtrc211h+SKXoT4w/Tf4tfHUYePizA6aWB4qBI51ii6i+OESfdkh+LxZPMgdD aZ2MZtTNiaB6YKC30higyeDrUZSAZG//zvidBqZC1xGJJiZkKXSUXGY+XAEiuVE32+9H xE28E/dUg4NXKY47I+GdBux0ShWje9QTNPQuemijcrlfDf66SJ4xz2Weh/f3thuLOFkY jpyGObvpvTlGCmIfcl0IM2LR6yOaa3OcConLJjcu8bFI1+rD+BIkYuxBmg2uaHZvjMQ5 Dl2w== X-Gm-Message-State: APjAAAVcEn3oxrh5+zyQENa+eQ5SXyC12g4h9wFUNr0SA0UFWJ8YkIQL rEhkyLjSUoN0HXW0LYU+jte/wA== X-Received: by 2002:a24:f942:: with SMTP id l63mr3031065ith.52.1556827914127; Thu, 02 May 2019 13:11:54 -0700 (PDT) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id 7sm46112iog.26.2019.05.02.13.11.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2019 13:11:53 -0700 (PDT) Subject: Re: [PATCH] mmc: Fix tag set memory leak To: Raul E Rangel , linux-mmc@vger.kernel.org Cc: avri.altman@wdc.com, djkurtz@chromium.org, zwisler@chromium.org, Ming Lei , Adrian Hunter , Hannes Reinecke , linux-kernel@vger.kernel.org, Omar Sandoval , Ulf Hansson References: <20190502190714.181664-1-rrangel@chromium.org> From: Jens Axboe Message-ID: <9233014c-8528-6cae-c48a-5b75160fa100@kernel.dk> Date: Thu, 2 May 2019 14:11:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190502190714.181664-1-rrangel@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/2/19 1:07 PM, Raul E Rangel wrote: > The tag set is allocated in mmc_init_queue but never freed. This results > in a memory leak. This change makes sure we free the tag set when the > queue is also freed. Reviewed-by: Jens Axboe -- Jens Axboe