Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp7647440yba; Thu, 2 May 2019 13:40:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTfRJ8wg0TIA1tWVs3MV/Te7atXQ0MuPpUkiYS57hb4OEg+lzRRspP6EF9Pm32oqWt3pUO X-Received: by 2002:a17:902:6946:: with SMTP id k6mr6001432plt.81.1556829617439; Thu, 02 May 2019 13:40:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556829617; cv=none; d=google.com; s=arc-20160816; b=fwhKWDYsLcQUsFyGRpx4GPcHYUmp3e71YC5szH/scrKBVnA7SekfCkvFpQAimeSSZh tx/q2m3Qf6RFn6Dd93l7CCfqKVFDhm5m7He3zsNAXxNU7USRpHRWLSFE3X2H5Yov0BHC H9qMXFqH2SBXf5B0CxW/ulrKWc3HvWWuSoV5lDka/PSuNdRd1IaK8U1KV+eo62+flqjU R+GppLJETJJC0XrQQTCu3vRgrWedL8bMarQPTbSHjMS1gwiyPcBTCFSnmVBan4uzEW7E 9DMdq/MSJ+zDiJ+tJyUfk0k3uLmxwHpPSKNSOOof+4KolwT6IINmxrRkT2whPiXgmwhi LntA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=wUZCuohdRKoDtwCw7rpSCNfQpmZ2G6kYAjwgGTNQOmk=; b=ACbpcNBemY1Tk/irEJ8mmeFiS01kDDGHU/Np4zLnImp4ta4PVAp+9nz5e6S0oIBBkM bDctMUJGuVjPvKdokLISLl88e1Lu3W8jafRvvDrTdxOdmnjNEQ6ms52ylois4y7MSk60 iuifm7RDXjZPC6MbpMnnUPk3LJ+AkzjodmTassBKjQqha39ecUjtaLiB4cZAVWZWmZug drHdxhxpOPe6XQVjlm2H7wAkWr0CzRj7zP0cY5n2cwmLcfGACdZrQGJTpJ1o8ygwmQQA ocSnr2l6/A8dTgFx/zIh4wDWrwJRG05Czs4XTgirL7aCwn9PuO42sjd8iCXKl+obuDKc OQ7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="UL/vJ9zw"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p4si49504pgh.526.2019.05.02.13.40.02; Thu, 02 May 2019 13:40:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="UL/vJ9zw"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726412AbfEBUh7 (ORCPT + 99 others); Thu, 2 May 2019 16:37:59 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:52393 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726376AbfEBUh7 (ORCPT ); Thu, 2 May 2019 16:37:59 -0400 Received: by mail-it1-f196.google.com with SMTP id q65so4306575itg.2 for ; Thu, 02 May 2019 13:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wUZCuohdRKoDtwCw7rpSCNfQpmZ2G6kYAjwgGTNQOmk=; b=UL/vJ9zw2ioEKKKIQPsBxyn+pcvK4SshzyL4jwE2DLBZ40sI2VmgnFtY95pCp6xBjl Nnm7LD0T5RrgyWR/xy6hiQcO55VV/duS1znRkktfTcQJ+xK25xhDxr28oXsJs68rzx9h XgYTK155M2n1HtMp3DGOreTHVM3F76w3f5GiWKA9UA9FzRflL8ErFclqPNJezVVk7tdr 6c4RaaXHRJkOpLvU2Iz64zIrSXtkiTXdkUtHXj4+eVN3WEB0ee2VNSH9PicGf81/PZcb zSGzrl3EXAlMmmcN+3++/C/DJfFZNREMBxgYqR8SRziOTv6A10rI8PSdhDhpBswFNwDv Fw6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wUZCuohdRKoDtwCw7rpSCNfQpmZ2G6kYAjwgGTNQOmk=; b=Foqmi1voHcBcVIIowW20shsVbCk9WafaoOPjTwF17s3ILM7JdLPWOlsEc+CDnJpNVS hkI176IApCKJncBZUJGVgMzhSK9jR4afKfzfLwcgcGni+ygQyhJVuh8NkHrmfM9vtj0a i4BxIR6DT+rc8/cc9xnNBHMCDHk1Cg/LFCC0lMX9hpnLW1Mcyt6PgjHo2nl7uafHmTw5 /PMzM35Q3MYuuVFSdRyDG4FeQboV1+kwkurCmAfm86+GPwXuXQQRQoRYldnUdIsEwMP1 ST7IvoSLHwZBlnMeoWztnTJ4Tz3kJO2Mjo8kYl5X22crSzVclsZyuFB67HV+piukYyp7 P/Fg== X-Gm-Message-State: APjAAAVsRpe+bIt+SOlNLlxXJI3DQV2LBll0Rnf3jfffC5LnQqkOk7th pqmP/AV9KKF2L4NToCzbNM+8Aw== X-Received: by 2002:a24:ee83:: with SMTP id b125mr4585381iti.43.1556829478105; Thu, 02 May 2019 13:37:58 -0700 (PDT) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id d4sm65586ioh.35.2019.05.02.13.37.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2019 13:37:57 -0700 (PDT) Subject: Re: [PATCH v2 1/3] blk-mq.c: Add documention of function blk_mq_init_queue To: Marcos Paulo de Souza , linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org, Chaitanya.Kulkarni@wdc.com References: <20190416032801.200694-1-marcos.souza.org@gmail.com> <20190502020455.GA71748@laptop> From: Jens Axboe Message-ID: <698e2ef1-e45a-e66b-f604-5c6bf76c40b5@kernel.dk> Date: Thu, 2 May 2019 14:37:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190502020455.GA71748@laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/1/19 8:04 PM, Marcos Paulo de Souza wrote: > gentle ping v2. It's not that I hate the series, I just don't see it adding any real value. It should already be quite clear what the functions do, by name, and the comments don't really add to that. -- Jens Axboe