Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp7661492yba; Thu, 2 May 2019 13:58:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqySN0mh/KojSkJ376GrYoop8iR8zTrNAfjopoJ6N1/eVW3m+hrpILczAEbHuxaXsMcvIIN1 X-Received: by 2002:a17:902:e70c:: with SMTP id co12mr5957531plb.339.1556830699444; Thu, 02 May 2019 13:58:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556830699; cv=none; d=google.com; s=arc-20160816; b=f+hwpkRR+iqKWtaWBuojT4mBycc4dQOWulCYR7cY138em0cKgKSAzJi5AMxEnS5yEw wqNLppzuzod5CuG4zOjzi5zNYwwuXT8qZaN4zMQGmbZgqBsAotrmHO3EaB6WGGUk2eeK CSnA2tllmHDHwUK4DGjnPTieu+TLZgKNSkKl331OiXxqZB5dmAhs7GthOSGXstNA67Hw WX1e9/h9nysODTJ4bwjd3MSblyZx2xRt+fsVT/B0My4VhEhfQQDC07EsMMSHS/1xJ10v U0YSeLo4w596EkYH+OVXXkqa7ZblKJw6AY/vBgIxDSZwAETu8Lf8LLrrXRd7uKZgHL8v W78Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=e/6b1F0TJTMRM3bfudiWiJdDExYB3o0dmMac3po5ink=; b=JD2raHY0wzhZu/NNrD33DpU6W5THf1Sfw99W0Is+5u7m0O1ymWHmGaZIW2jVbl7d0L hA34n23S2uM3GwjfLBoLnTP9EDTB/CGycuNxp/zSEjuV/M9i2BKVjlk8iok+FQ7IeTlQ zcM8MFlmLZ+dph0oRinggMG7NrqDX29mstSZEFWhWWPJL2sB+f6Va1aKTyPWme3ls7/1 jeWQUTu1Bhw/4ECzYHnq8wXYo4Yyz6wRZWZnSx7ny8aBC2dsDq+DKQRJriUdll52++Pu d2Ga5G9ZvC41e0x1TEPJA61VA5lkdH37oj+giLBIlEdSNizRpoe6wDHglAG0zMulf4Bu owkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k3si80686pfc.91.2019.05.02.13.58.03; Thu, 02 May 2019 13:58:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726412AbfEBU4w (ORCPT + 99 others); Thu, 2 May 2019 16:56:52 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45301 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbfEBU4w (ORCPT ); Thu, 2 May 2019 16:56:52 -0400 Received: by mail-pl1-f193.google.com with SMTP id o5so1566763pls.12; Thu, 02 May 2019 13:56:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=e/6b1F0TJTMRM3bfudiWiJdDExYB3o0dmMac3po5ink=; b=G/eFiqRfOPiNA1yZV8oC+zbplftBOSt3SL1C8IsDOldBaxR4xLylUA0g+JJF4J3V07 9Ce4KTDXyW7RuKDXScx4pdKpwzmYxwTTKwfqeibgU7tlqVfF7kBYZ4Xm+z6rXZuhIBj5 duCpDtMJAsy5K8WS8Vnlg5tt6iC2+ZcCQI0FOFoXe9jn9vwX3bwL1GhFtf43f+iVvEKl 5ktzJBQ9qk4UoDCMhfg60cpkqJzQGEmgc0PpeokGx9Hos7seYqqDqYIl4VpJY/LthOsj isVF0zfBPuO07Jr7P2nZHhG7V/aswsfIi/TDh5lm6intGeC/ik9MQoYKbJLnxfU+ng9b NfZA== X-Gm-Message-State: APjAAAXNT2bFO4EnAFVZsutoTBejaGCLMhzdNMlDV/PCbiWuwzYhacfl XCKeZs7LE9ceCcdXcKa9atg= X-Received: by 2002:a17:902:3324:: with SMTP id a33mr6137181plc.18.1556830611449; Thu, 02 May 2019 13:56:51 -0700 (PDT) Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id l63sm80022pfb.124.2019.05.02.13.56.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 13:56:50 -0700 (PDT) Message-ID: <1556830609.130741.0.camel@acm.org> Subject: Re: [PATCH] block: Fix function name in comment From: Bart Van Assche To: Raul Rangel Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe Date: Thu, 02 May 2019 13:56:49 -0700 In-Reply-To: <20190502205109.GA103782@google.com> References: <20190502194811.200677-1-rrangel@chromium.org> <1556829225.12970.10.camel@acm.org> <20190502205109.GA103782@google.com> Content-Type: text/plain; charset="UTF-7" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-05-02 at 14:51 -0600, Raul Rangel wrote: +AD4 On Thu, May 02, 2019 at 01:33:45PM -0700, Bart Van Assche wrote: +AD4 +AD4 On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote: +AD4 +AD4 +AD4 The comment was out of date. +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 Signed-off-by: Raul E Rangel +ADw-rrangel+AEA-chromium.org+AD4 +AD4 +AD4 +AD4 --- +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 block/blk-mq.c +AHw 2 +- +AD4 +AD4 +AD4 1 file changed, 1 insertion(), 1 deletion(-) +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 diff --git a/block/blk-mq.c b/block/blk-mq.c +AD4 +AD4 +AD4 index 9516304a38ee..0e467ff440a2 100644 +AD4 +AD4 +AD4 --- a/block/blk-mq.c +AD4 +AD4 +AD4 diff --git a/block/blk-mq.c b/block/blk-mq.c +AD4 +AD4 +AD4 index 9516304a38ee..0e467ff440a2 100644 +AD4 +AD4 +AD4 --- a/block/blk-mq.c +AD4 +AD4 +AD4 +-+-+- b/block/blk-mq.c +AD4 +AD4 +AD4 +AEAAQA -2062,7 +-2062,7 +AEAAQA void blk+AF8-mq+AF8-free+AF8-rqs(struct blk+AF8-mq+AF8-tag+AF8-set +ACo-set, struct blk+AF8-mq+AF8-tags +ACo-tags, +AD4 +AD4 +AD4 list+AF8-del+AF8-init(+ACY-page-+AD4-lru)+ADs +AD4 +AD4 +AD4 /+ACo +AD4 +AD4 +AD4 +ACo Remove kmemleak object previously allocated in +AD4 +AD4 +AD4 - +ACo blk+AF8-mq+AF8-init+AF8-rq+AF8-map(). +AD4 +AD4 +AD4 +- +ACo blk+AF8-mq+AF8-alloc+AF8-rqs(). +AD4 +AD4 +AD4 +ACo-/ +AD4 +AD4 +AD4 kmemleak+AF8-free(page+AF8-address(page))+ADs +AD4 +AD4 +AD4 +AF8AXw-free+AF8-pages(page, page-+AD4-private)+ADs +AD4 +AD4 +AD4 +AD4 Does the entire comment fit on a single 80 column line? In other words, can +AD4 +AD4 the comment that is spread over four lines be reduced to a single line? +AD4 +AD4 No, it would put it at 91 characters long. That's unfortunate ...