Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 May 2019 17:12:56 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Viktor Rosendahl <viktor.rosendahl@gmail.com>
Cc:     Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH v2 4/4] ftrace: Add an option for tracing console
 latencies
Message-ID: <20190502171256.0ecd0f20@gandalf.local.home>
In-Reply-To: <20190502183731.9571-1-viktor.rosendahl@gmail.com>
References: <20190501213857.157e3741@oasis.local.home>
        <20190502183731.9571-1-viktor.rosendahl@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu,  2 May 2019 20:37:31 +0200
Viktor Rosendahl <viktor.rosendahl@gmail.com> wrote:

> > Instead of this being turned into a nop, don't have a kconfig option
> > but instead have this call into the trace_irqsoff.c code, and depending
> > on what the options are, it should stop it. Of course, this would need
> > to be smart enough to pair it. Perhaps return the result of
> > console_stop_critical_timings() and have that passed to
> > console_start_critical_timings(), and only have start do something if
> > stop did something. This way the option only needs to disable the stop
> > part.  
> 
> Something like this?
> 
> I have only compile tested it so far.
> 

Yeah, something like that.

-- Steve