Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: <lipeng321@huawei.com>
Subject: Re: [PATCH net-next 1/3] net: hns3: add support for multiple media
 type
References: <1556679944-100941-1-git-send-email-lipeng321@huawei.com>
 <1556679944-100941-2-git-send-email-lipeng321@huawei.com>
 <20190501123750.GA9844@lunn.ch>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>
From:   "lipeng (Y)" <lipeng321@huawei.com>
Message-ID: <1d7faec8-22f7-0e8f-7e38-9ad600134a7c@huawei.com>
Date:   Fri, 3 May 2019 11:13:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20190501123750.GA9844@lunn.ch>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/5/1 20:37, Andrew Lunn wrote:
> On Wed, May 01, 2019 at 11:05:42AM +0800, Peng Li wrote:
>> From: Jian Shen <shenjian15@huawei.com>
>>
>> Previously, we can only identify copper and fiber type, the
>> supported link modes of port information are always showing
>> SR type. This patch adds support for multiple media types,
>> include SR, LR CR, KR. Driver needs to query the media type
>> from firmware periodicly, and updates the port information.
>>
>> The new port information looks like this:
>> Settings for eth0:
>>          Supported ports: [ FIBRE ]
>>          Supported link modes:   25000baseCR/Full
>>                                  25000baseSR/Full
>>                                  1000baseX/Full
>>                                  10000baseCR/Full
>>                                  10000baseSR/Full
>>                                  10000baseLR/Full
>>          Supported pause frame use: Symmetric
>>          Supports auto-negotiation: No
>>          Supported FEC modes: None BaseR
>>          Advertised link modes:  25000baseCR/Full
>>                                  25000baseSR/Full
>>                                  1000baseX/Full
>>                                  10000baseCR/Full
>>                                  10000baseSR/Full
>>                                  10000baseLR/Full
> Hi Peng
>
> If it does not support auto-negotiation, do these advertised link
> modes make any sense? Does it really advertise, or is it all fixed
> configured?
>
> 	Andrew
>
> .
Hi Andrew:

it makes no sense when auto-negotiation is not supported.
I should handle it differently with the case supports auto-negotiation
and not supports auto-negotiation.

I will fix it in next version, result like below:
Settings for eth0:
         Supported ports: [ FIBRE ]
         Supported link modes:   25000baseCR/Full
                                 25000baseSR/Full
                                 1000baseX/Full
                                 10000baseCR/Full
                                 10000baseSR/Full
                                 10000baseLR/Full
         Supported pause frame use: Symmetric
         Supports auto-negotiation: No
         Supported FEC modes: None BaseR
         Advertised link modes:  Not reported
         Advertised pause frame use: No
         Advertised auto-negotiation: No
         Advertised FEC modes: Not reported
         Speed: 10000Mb/s
         Duplex: Full
         Port: FIBRE
         PHYAD: 0
         Transceiver: internal
         Auto-negotiation: off
         Current message level: 0x00000036 (54)
                                probe link ifdown ifup
         Link detected: yes

         Wish I have understood your comments correctly.


Thanks!


>