Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp106112yba; Thu, 2 May 2019 21:04:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqyEGEHdDxqP+W0GI+JVfvoku94YsN0a2CdbiRM5PN52fQidzfC96hQS9Sm4S3XKfO6RZeZx X-Received: by 2002:aa7:925a:: with SMTP id 26mr8033578pfp.152.1556856250216; Thu, 02 May 2019 21:04:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556856250; cv=none; d=google.com; s=arc-20160816; b=zEapiYK+Vs+n2mwwTbjz08BQc7kINIGUswpMX1fRha+sEa2RurQUWY9VVwvEtLNlXw mdExvem+fLPMGnoa5cc2axs9kOvhcRGVfeWjG4t1dfp38JmK7uxnBKUeH6QAvBuhlsaF Q8vz+tLERjojaRUrj81/B3b9uYV/xsLhO4sLAwPAC1alNkM1ezMGpYKlv8vqbK0nQ/Mg m1uQ4KFy+QMW7GbqR13v4GZ+Xrc4X/700Tzo5FDHUdLLv1nWsVLjluLcT8f2K4331HAm Cwg/0irwSG5lyI2LripX5F4cQjNBBP7ZuotV6jsFQ2AvHvmrcUcVubZ/3r5GDGzlKF2c DWzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=1/+exJcDLfJMbpm+cistYabfcZnJTfblqaDhmOStGDc=; b=hi9Hq3bcBjshxKUTsTYPGt/fGVk5FzbYjb46aT6fmcN3IlrG7y6aKdcgcRtQ6jqdvi bsfl6mIRZg333eYBqH5mitn/3SLi2wSLtTgKhaHguw2KKvCp0y8Kxw5+O0MKiq98hTec BlMsldyO3Y9fpPI5mpC9O3tPH93zOwnrve/FOgEU/WsNndu+kCWifOkEcGEFWhKwTs3l oTsa5+kUtgWxqb3HOFmsDr/Y6Jeir6ada3x3AbATWO8iQYEUpBsbL43RHwljWewAh8pf fi6y02y/+RbFVfNPmzQxk0zlhwWPw1upCrg9WpG4AYj3MxChcdC3Ca5t/fSnDNIjmIXC ZBSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fredlawl-com.20150623.gappssmtp.com header.s=20150623 header.b=nvECSvTh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i195si916607pgd.521.2019.05.02.21.03.54; Thu, 02 May 2019 21:04:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fredlawl-com.20150623.gappssmtp.com header.s=20150623 header.b=nvECSvTh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726573AbfECEAx (ORCPT + 99 others); Fri, 3 May 2019 00:00:53 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:40652 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbfECEAd (ORCPT ); Fri, 3 May 2019 00:00:33 -0400 Received: by mail-oi1-f195.google.com with SMTP id y64so3468798oia.7 for ; Thu, 02 May 2019 21:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fredlawl-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1/+exJcDLfJMbpm+cistYabfcZnJTfblqaDhmOStGDc=; b=nvECSvThLrCazQlaGUsoBn+Ui6ihMBY7wWIM7KpRqGCHm3faImkNGEAOL4e0hphmqf Rtjac3o7G3pGAA3LCozC6SpisiJ1HdY3eONMMeKxwbwpIBT8T4GqX12NwX2yG4YbE6CZ fBPB4BJGzvtbZFMwOlAdOgwWli2RinSwCeqqxbwCMJ5ItvZWhtRCwGufz8Wn7KOaCyJT x58XK1qYNc+nuBqNe25MngzYJF34fGol1JOlNatFnGG/iZS3/BFOB94UjqWPu41UN/dD oCx1W6Kuf7/97ba3R5F0NPEOoYaRFCFEZl/lTvS9xXwTQgTam9YH4FgUIV3tR3cbSpyu xRNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1/+exJcDLfJMbpm+cistYabfcZnJTfblqaDhmOStGDc=; b=LstLWdSFznd6jUFVect7hUzaPy6gP65/wds7vN6NxDyDNCE5fIvVIHGPmLQfLWvcSH rZV4zBjT2SB9Z3Y6klYsnazuekIA0jn/eehFuL7y0xmlnhLsDHN9AzH+3RH3/P/+kgF1 /M1HSPVy0IGiZZpDW/mPnU0anyYkvRxJbBtD/+J82lyTov5PxKSuTvJwVH2OEKAoX7TH aXL6gkVpVDpHAMEzB1zcl7Sj+jBO6L47DjuHhnQ7PpH50rblJlx10cqC4ORvTI3yD0Oc 5WjFgwyNx9u0SlPCcvOfL0SJ7MOBojwnvhIU+wFzJ6zMaOFq8gawdGV3U+JNH/iHTq8c dv1Q== X-Gm-Message-State: APjAAAVdi6h74QERPV2LIE5zg3IuoxXE+gDCUb92ATr6Rij/5DU81jta y/jdfDFdXMizcdpSSaYUxpKdng== X-Received: by 2002:aca:cc90:: with SMTP id c138mr1851704oig.97.1556856033029; Thu, 02 May 2019 21:00:33 -0700 (PDT) Received: from linux.fredlawl.com ([2600:1700:18a0:11d0:5518:38b8:ef25:393a]) by smtp.gmail.com with ESMTPSA id b23sm403696otl.55.2019.05.02.21.00.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 21:00:32 -0700 (PDT) From: Frederick Lawler To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, lukas@wunner.de, andriy.shevchenko@linux.intel.com, keith.busch@intel.com, mr.nuke.me@gmail.com, liudongdong3@huawei.com, thesven73@gmail.com, Frederick Lawler Subject: [PATCH v2 7/9] PCI: hotplug: Prefer CONFIG_DYNAMIC_DEBUG/DEBUG for dmesg logs Date: Thu, 2 May 2019 22:59:44 -0500 Message-Id: <20190503035946.23608-8-fred@fredlawl.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503035946.23608-1-fred@fredlawl.com> References: <20190503035946.23608-1-fred@fredlawl.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dbg() and ctrl_dbg() requires pciehp_debug module parameter to be set for debug log purposes. There are niche situations in pciehp_hpc.c where pciehp_debug is used: dbg_ctrl(), and pci_bus_check_dev(). Enabling CONFIG_DYNAMIC_DEBUG/DEBUG is well known for logging debug information. Therefore, prefer pr/pci_dbg() for debug information, and reserve pciehp_debug for niche situations. Signed-off-by: Frederick Lawler --- drivers/pci/hotplug/pciehp.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index 78325c8d961e..e852aa478802 100644 --- a/drivers/pci/hotplug/pciehp.h +++ b/drivers/pci/hotplug/pciehp.h @@ -32,10 +32,7 @@ extern int pciehp_poll_time; extern bool pciehp_debug; #define dbg(format, arg...) \ -do { \ - if (pciehp_debug) \ - pr_info(format, ## arg); \ -} while (0) + pr_debug(format, ## arg); #define err(format, arg...) \ pr_err(format, ## arg) #define info(format, arg...) \ @@ -44,11 +41,7 @@ do { \ pr_warn(format, ## arg) #define ctrl_dbg(ctrl, format, arg...) \ - do { \ - if (pciehp_debug) \ - pci_info(ctrl->pcie->port, \ - format, ## arg); \ - } while (0) + pci_dbg(ctrl->pcie->port, format, ## arg) #define ctrl_err(ctrl, format, arg...) \ pci_err(ctrl->pcie->port, format, ## arg) #define ctrl_info(ctrl, format, arg...) \ -- 2.17.1