Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp156518yba; Thu, 2 May 2019 22:27:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqzhIns1gGWf00Tgmjdcdo9RJoBAJ2V5Dcz6ArNxNpPaovDUxHs38r3ZMBptZPGGnR24yK9H X-Received: by 2002:a63:6981:: with SMTP id e123mr7761262pgc.28.1556861243814; Thu, 02 May 2019 22:27:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556861243; cv=none; d=google.com; s=arc-20160816; b=VBRzKeyfNfWZc65rmGNY5WtIlW0wp/osrdUthVZbwOgRUQ0zIjiHyUR17mBE/KkWte Lc6EkdhO6wpaH8qAbSEy1TgFe6eYZbqmeBJqD4bedCEGL/RGjtMF9cRlH5Qs2JUBWCu0 R/mIaY62xnrmnmfcGfm0wheV2e7y30+XoFW0+mvkkn6xNwbRGx9FKNNEdQUyIQ/J8isB zAGhkXVvK27iOQ7FRIQWKK1IPGcIzBVJ7SPQG2up021Z/Slm7k4lhP26NsRtaodS4zMG FKNEmYPTeOfKhkf2Us5BtLftXYNLBHZ0kZMkCbDEUOJrnmwzGfsSbs3ChLIIuq+ivAO6 WKUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ajr35B0OPmYp0uksnhPeXTb1xq5aJvRQAQZCo3Hnvqc=; b=Svojkkc4nuM8BcmvxtGh0PdT10KxL0uhnTIgenHTxZ+unyoncmCCBsrcrhh9NTpDDD RK0YEc9CBtHck4EQn5YagCZvZ3hIxOe6QEIN5aI488/exior/Mz0+K7D+9y7y4jQg15y yn64aA0pdea1zWkjDp7SyQua9weLgin6VoFKjqbpYyQrWRPcKknmasNczcbgbx6yYa+D HK5AnC9AqHMiUMkNIyukBpS3X9nOakeT1IM5GGM80rrHCX2kND3dwjqN1gFG+L1hxxyV VrJyyI5ax8MW7gJLEXYYAOS9jhwL8PWVRv3ZmHdhUyPfP8baNAQOqzG+wud2hjNpka8l sXEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=GjpsXnCf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w15si1080447pgj.427.2019.05.02.22.26.35; Thu, 02 May 2019 22:27:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=GjpsXnCf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbfECEei (ORCPT + 99 others); Fri, 3 May 2019 00:34:38 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:46952 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725308AbfECEei (ORCPT ); Fri, 3 May 2019 00:34:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ajr35B0OPmYp0uksnhPeXTb1xq5aJvRQAQZCo3Hnvqc=; b=GjpsXnCfliyL5USC5eNrbk0+o z8VfBbhpBwFeU5JNq1JkwWuTcjA15f+9GN5XbnPHOIPoWD2vwiwWC/Lv0+pfScgiYDMQKOdNAaDn/ qTFSnDQ1yfsf3DoVw1VCHIOOhFnKs+PY8XxE8wTlki+9B15LVGE14dO+C7BKcqELpQRy4=; Received: from [42.29.24.106] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hMPts-0000MQ-Io; Fri, 03 May 2019 04:34:21 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id EAA20441D3C; Fri, 3 May 2019 05:34:06 +0100 (BST) Date: Fri, 3 May 2019 13:34:06 +0900 From: Mark Brown To: Ross Zwisler Cc: Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Ross Zwisler , Jaroslav Kysela , Jie Yang , Liam Girdwood , Takashi Iwai , alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH v2] ASoC: Intel: avoid Oops if DMA setup fails Message-ID: <20190503043406.GZ14916@sirena.org.uk> References: <0b030b85-00c8-2e35-3064-bb764aaff0f6@linux.intel.com> <20190429182517.210909-1-zwisler@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p+/4B2pcxE3X6xU6" Content-Disposition: inline In-Reply-To: <20190429182517.210909-1-zwisler@google.com> X-Cookie: -- I have seen the FUN -- User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p+/4B2pcxE3X6xU6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 29, 2019 at 12:25:17PM -0600, Ross Zwisler wrote: > Currently in sst_dsp_new() if we get an error return from sst_dma_new() > we just print an error message and then still complete the function > successfully. This means that we are trying to run without sst->dma Please don't bury patches in the replies to existing threads, it makes it harder to spot them. --p+/4B2pcxE3X6xU6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlzLxL4ACgkQJNaLcl1U h9Bf5gf/b4Rd4TJAVsVpVmu3GoujrMqNu/jOVgDjPKDNLE70Cj/x4nvuVMvV6YAA 1W93C0kngsJWKhAgw3gvDsW2iIBGRLOCxB0JaHXntb5bO1ruAMKvyDfy1E09038c RvoJg8367XfDLvnJKgoaktPKu+d4yPf73shGOVgEpSEvT5vs4bl5/zV1tB3NNHMG U5QkmT8AoRhkDRWOrIETSfPaZJwk01VI7qjp9UxSqszBvbcxhwMbuDPyCcr5reXn Q5aYlCH8a1mZoW4Az6NHsykSi8NyqPt1rvKYStPQn4WsasuXkV406EddfJL98bI1 I/gMNH5m5xTM4wPel4/Bi8jxQQ+V5w== =A4ke -----END PGP SIGNATURE----- --p+/4B2pcxE3X6xU6--