Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp172529yba; Thu, 2 May 2019 22:52:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFHRBa8OSfgcqozWtGZvkHjH768nBCfEV1llPgVoxAl9c+x92UiMgDIzEswXRtJH/Dn2BQ X-Received: by 2002:a65:6205:: with SMTP id d5mr8161114pgv.61.1556862763146; Thu, 02 May 2019 22:52:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556862763; cv=none; d=google.com; s=arc-20160816; b=cEupTgSQBWQ7JbUPjmOrgSRb2uzxJwCnSM9wDb1GRJ9/tsl3KR++vzUzFhrORFqF7m tknTIJwKF0kWc4/X62zx0qA0/G9h9Wd5DDIpuCxRspM6mrqXFaadh5M47rAyW3ZjmbW4 p82q21GJs09J+9ayYDNkOFXBpbC2KwsPJGRNEFePJOzKcE/J5i1jTFVTgJ/tL4URqDZt TJIiB/POPbrhlAtqf/yx/woy7rCvsvljgKuYbczubpEPYvbvAZj6H+pCkCMs72bVV7Ns 2WIrUDp2LEv/INwGsiTeSPOi+WaF9icJDBSjYAkCw29ypbfQ4Dks2ki/veHooSvFRtxn o19g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=XGJGQ0plKJcdTluDLLxpFyAzHcNzmyrBbZr3k5m4ox0=; b=QkMCis87xmiYWIw+1EKHu8Lugu00vnF/aGZiELzKTg6XOwMo+5DSc5S6fZbZ7J6KJb HC9wY2wU1CYlxT26rT50TBXhzPrdzXqzANVW2fEjUw3F6+f8Ch9lKVwll16Vk1+b+BEG PUdkRMf/5r2cQ8jxwvJCDgHzGGvC5IiexJjsxIdWPknoa/ySYA/+DO//CEiYano4M6r5 dNYH1y2E+oilXOs7Yhf/yfZVQe5DbpUdjwGAotJbqlrk866CPP5t8vK+kO3QMod/4aVN RpVMNZR0pmFfWJULcpqw+gLuZWObCzPVqaAw9nECJFpjWahk9SGyqPg2l2yhMz1ms9Il VwKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h6si1080348pgv.302.2019.05.02.22.52.27; Thu, 02 May 2019 22:52:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726611AbfECFtb (ORCPT + 99 others); Fri, 3 May 2019 01:49:31 -0400 Received: from mga14.intel.com ([192.55.52.115]:34827 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbfECFtb (ORCPT ); Fri, 3 May 2019 01:49:31 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 22:49:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,424,1549958400"; d="scan'208";a="167149143" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.189]) by fmsmga002.fm.intel.com with ESMTP; 02 May 2019 22:49:27 -0700 Date: Fri, 3 May 2019 08:49:27 +0300 From: Jarkko Sakkinen To: Matthew Garrett Cc: Bartosz Szczepanek , linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?iso-8859-1?Q?Thi=E9baud?= Weksteen Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table Message-ID: <20190503054927.GC3728@linux.intel.com> References: <20190227202658.197113-1-matthewgarrett@google.com> <20190227202658.197113-3-matthewgarrett@google.com> <20190502083240.GJ14532@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 11:03:08AM -0700, Matthew Garrett wrote: > On Thu, May 2, 2019 at 1:32 AM Jarkko Sakkinen > wrote: > > > > On Tue, Apr 30, 2019 at 03:07:09PM +0200, Bartosz Szczepanek wrote: > > > I may be a little late with this comment, but I've just tested these > > > patches on aarch64 platform (from the top of jjs/master) and got > > > kernel panic ("Unable to handle kernel read", full log at the end of > > > mail). I think there's problem with below call to > > > tpm2_calc_event_log_size(), where physical address of efi.tpm_log is > > > passed as (void *) and never remapped: > > > > Not late. This is not part of any PR yet. Thank you for the > > feedback! > > > > Matthew, can you send an updated version of the whole patch set > > with fixes to this issue and also reordering of the includes? > > Yes, I'll resend and let's do this again for 5.3. Agreed, better not rush but get it right once. /Jarkko