Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp172755yba; Thu, 2 May 2019 22:53:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzqvYOD3H4RehJ6DMVlFL0GLslEAnzJ9UWcH9U9llsjw2hlrTFfA/aw2PIs4yDgukT9uUid X-Received: by 2002:aa7:9085:: with SMTP id i5mr5607973pfa.209.1556862785344; Thu, 02 May 2019 22:53:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556862785; cv=none; d=google.com; s=arc-20160816; b=v+mmZ4hce+jZs0Bkklf9pHrrhsW8tpBh5NyvFNLyv9VSTU6TI96qwpWAcpt+NGBj+7 wKUpKhbW/mGSE7IYfLHE6Y6yIBTkGd58pyBICoAeRgNSyW5A8+Al0iAJd298p5Tgz6LV fqWfAR/of6o9l6n+lbmiz4wirvscDGmJX3xItZW3dY7+yyIvARaEjWddvyVrQTiSOxNz klQ5UjEoq/yHDWS0XWW+rWg+RsUNQhlRNLzMhGdi5j2hizJmFR4/f/u2RUv6FTUoYtkc TZIwCIFdLDizQLlQq5mcNayPImWUtgXcpFOwQLU7TK/UIaqf1w+b3QK54cO7gkW4uBxS FDIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=eXQ+p6Bj2+GVdegZf9FUlJuusRtp1XjALduZom5EHgQ=; b=HPaNpA9YOf3Rwh+sLRo9FKxLn3ud8ql339rsa734chhNpnFf9ZTeJEsBTtfZ2aDsRd wGh4h6rS8LVk7fYsCHuU0jpRhs9YgnwqYtUzNFF6dd/fPeydeMtSvQXFpRc5pgr9e/IB JP8vor2FJ5cBIMj3bl6C/Ii7TdNUH/ujfCjtgoA7FQx6JM6kaYIEN7coiYeH54+m8l1o 285IBgAYIIZMRc0RYTSgx8paKjorP5UFDIphYaCvvCVk8zw088OvGWtrHKupTIYXSHoa shx7iotH0zGhXEmBjvQztectgT4rxnpM2233qPdtR54RXBilOAml1XKaM8zynrL/tHxK B3Nw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si1129222pgc.304.2019.05.02.22.52.50; Thu, 02 May 2019 22:53:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfECFva (ORCPT + 99 others); Fri, 3 May 2019 01:51:30 -0400 Received: from mga05.intel.com ([192.55.52.43]:61367 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfECFva (ORCPT ); Fri, 3 May 2019 01:51:30 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 22:51:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,424,1549958400"; d="scan'208";a="167149467" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.189]) by fmsmga002.fm.intel.com with ESMTP; 02 May 2019 22:51:26 -0700 Date: Fri, 3 May 2019 08:51:26 +0300 From: Jarkko Sakkinen To: Ard Biesheuvel Cc: Matthew Garrett , Ingo Molnar , Bartosz Szczepanek , linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?iso-8859-1?Q?Thi=E9baud?= Weksteen Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table Message-ID: <20190503055126.GD3728@linux.intel.com> References: <20190227202658.197113-1-matthewgarrett@google.com> <20190227202658.197113-3-matthewgarrett@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 09:14:49AM +0200, Ard Biesheuvel wrote: > (+ Ingo) > > On Tue, 30 Apr 2019 at 21:52, Matthew Garrett wrote: > > > > On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek wrote: > > > > > > I may be a little late with this comment, but I've just tested these > > > patches on aarch64 platform (from the top of jjs/master) and got > > > kernel panic ("Unable to handle kernel read", full log at the end of > > > mail). I think there's problem with below call to > > > tpm2_calc_event_log_size(), where physical address of efi.tpm_log is > > > passed as (void *) and never remapped: > > > > Yes, it looks like this is just broken. Can you try with the attached patch? > > I'm a bit uncomfortable with EFI code that is obviously broken and > untested being queued for the next merge window in another tree. > > What is currently queued there? Can we revert this change for the time > being, and resubmit it via the EFI tree for v5.3? Nothing ATM. The broken code is in my master branch ATM. Nothing in my next branch nor have I included anything to my PRs. Should be nothing to worry about in that sense :-) /Jarkko