Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp187468yba; Thu, 2 May 2019 23:13:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwANuh8SEDFp9FgIeaXM16cbOAPy0tmoeVBI8A+ma0t6lXWUiFzEO5GYCQJq+2FYyd89wgW X-Received: by 2002:a17:902:8306:: with SMTP id bd6mr8146761plb.134.1556864003199; Thu, 02 May 2019 23:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556864003; cv=none; d=google.com; s=arc-20160816; b=ilLeztMUW5aqGtmq23rVgE9xM3Zi6yXWH4yuix9AmaOg8bp97EiOS/FfvJ1mxyZkXd k/rboOQlyDKzgQnntIAEdtxbK5r5g0q0zFa/vkkRsVBWI1bWAInOp4ocw9I6qPh+O8D9 x6FcPhHMIJCZCJV/BurFCUKWdjtJGBcQI5xsJztZV5jLwBcsfgz+MmXNOCy66xR3cZwN kCLVd1Nx684ODj2/Os7HT94TQAatHWaZy61FmWgiy7GfTuq+XyAd04buzDUmEJyMBevB TlYKqiLWUd/xoPhljSU4iwWzNWaurV4IVbP02NXErhZqhJwgXYee2GFqn6Ix9i4HCUsh zXOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=6urN0N6tX2ZYDdvQKCY350dm472kjxrDHm47V2bdN3U=; b=Z9MrfiqbUMqGR/QaShQDfdQh3lGsJfe/F/eY00tvAQG/YBO2NLh7DaumLrx7gxsjyx Gu7N6WJlpOCe+QxtkOsNQikdOihdd4dn5MI8vYN0xkXnMwKQnnzmr5CAWZm9gtcnC+su d72uNOGTTEe8Po3M2IEri/UIvjcWWEAn+jv62Z9vfQBXNpGMkQMd7d3NAggMMibaY6ym 0MZOq2NM/t7V/mfzXAfEH6kOiNWOnrAao1hXSLjU4+tRzw3EJv2FoxVUbj5jWPdrzN8Q aK0QzTIwwBrdIO90JbYoA9ACZzztoBQNbRKGPCRGzwnbZCNpV3NRemTdM3MeOnlDckPM ZDXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n12si1338633plp.223.2019.05.02.23.13.07; Thu, 02 May 2019 23:13:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726593AbfECGMP (ORCPT + 99 others); Fri, 3 May 2019 02:12:15 -0400 Received: from mga11.intel.com ([192.55.52.93]:46409 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfECGMP (ORCPT ); Fri, 3 May 2019 02:12:15 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 23:12:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,424,1549958400"; d="scan'208";a="147784716" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.189]) by orsmga003.jf.intel.com with ESMTP; 02 May 2019 23:12:10 -0700 Date: Fri, 3 May 2019 09:12:09 +0300 From: Jarkko Sakkinen To: Ingo Molnar Cc: Matthew Garrett , Ard Biesheuvel , Bartosz Szczepanek , linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?iso-8859-1?Q?Thi=E9baud?= Weksteen Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table Message-ID: <20190503061209.GA5630@linux.intel.com> References: <20190227202658.197113-1-matthewgarrett@google.com> <20190227202658.197113-3-matthewgarrett@google.com> <20190503060218.GA28048@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190503060218.GA28048@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 03, 2019 at 08:02:18AM +0200, Ingo Molnar wrote: > > * Matthew Garrett wrote: > > > On Thu, May 2, 2019 at 12:15 AM Ard Biesheuvel > > wrote: > > > > > > (+ Ingo) > > > > > > On Tue, 30 Apr 2019 at 21:52, Matthew Garrett wrote: > > > > > > > > On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek wrote: > > > > > > > > > > I may be a little late with this comment, but I've just tested these > > > > > patches on aarch64 platform (from the top of jjs/master) and got > > > > > kernel panic ("Unable to handle kernel read", full log at the end of > > > > > mail). I think there's problem with below call to > > > > > tpm2_calc_event_log_size(), where physical address of efi.tpm_log is > > > > > passed as (void *) and never remapped: > > > > > > > > Yes, it looks like this is just broken. Can you try with the attached patch? > > > > > > I'm a bit uncomfortable with EFI code that is obviously broken and > > > untested being queued for the next merge window in another tree. > > > > The patchset was Cc:ed to linux-efi@. Is there anything else I should > > have done to ensure you picked it up rather than Jarkko? > > That's not the workflow rule the Linux kernel is using, if Cc:-ing a > patchset was the only condition for upstream inclusion then we'd have a > *LOT* of crap in the Linux kernel. > > Just applying those EFI changes without even as much as an Acked-by from > the EFI maintainers is a *totally* unacceptable workflow. > > Please revert/rebase and re-try this on the proper submission channels. > > Meanwhile the broken code is NAK-ed by me: > > Nacked-by: Ingo Molnar There must be some kind of misconception here. None of the changes have been submitted so far. They are only in my master branch. They briefly went to linux-next through my next branch but as soon as issues were reported I wiped them off from there (which happened like 2-3 weeks ago). They haven't been part off any of my PR's. There is nothing to revert. /Jarkko