Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp263067yba; Fri, 3 May 2019 01:05:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwm3Wz7/erimB/wXMHUF8qz/7CdMcnyOiKYZMVSDVdIXiBs+GrnSN5eceQYkhA6Aud37rxJ X-Received: by 2002:a62:5707:: with SMTP id l7mr9279463pfb.205.1556870745282; Fri, 03 May 2019 01:05:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556870745; cv=none; d=google.com; s=arc-20160816; b=oEbQ/STik6wDJ4LJP49VaIjNfFcABxZqOQASr5ngSCNyj0nR6OqJfhpIMwzBG3jUFe ACAEFVZson8HCVVmurIuhWBbKgtuXyz0oDxpBojIkEat5/lRl3WDu67bS8l2yItOGwr0 zZE7TBo9SMv/jl4eOIEndRXwBcrVY52AHyHhUHJDYXzh3vJOnkOODhcHamM8j0VkLhLL yfzyjWLa7k9b7n+d9/fDD26EYAl05tXNIJk78pwk7g9FG8CSAGcrVQE/bI1Oua8ojzx5 /kiBURXNnefdc80O+L88qdjOOfPWyo+rC4bkjc3YwGh+dYI7ydtj2eTmRkd123JujehL 2Wig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=QyYnh8hGNxo4y79JyoBAvnyJOsqV/eKCHgC2055Dj70=; b=ysMNoodPRwO19ZTNdPrQlZ91yiWrtyd4+K+hy2mauEt50RP8+1eIhcW4+AIrqrLP99 pUN+2G9vHZOj5H8aC369dZMbawfBx3TZ3nOq+9SR5EsUGMWzGjjUdZarwag5vd42OuHE b/JINXXiCd5vYO1XQ5TKvXBth74zbCYPbpPkZ+rgYJYNxnmRiKfPFNBkVV/kab0yE/8E K03Z5ry8obe4eZZRI4zV9JbItESB9No0gWnJpf6M1nx+uIW8st8VFHIMHvyfouPM9Dk0 eTrJah4EtGNO3tfnPqmCqmlxPR+Ckm4ShbffSnWrQLwgF3K6M8SLfYo1b89akBaawzaZ xzUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TFsaDfJk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5si1312783pgw.359.2019.05.03.01.05.29; Fri, 03 May 2019 01:05:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TFsaDfJk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725997AbfECIEL (ORCPT + 99 others); Fri, 3 May 2019 04:04:11 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:44540 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfECIEL (ORCPT ); Fri, 3 May 2019 04:04:11 -0400 Received: by mail-qt1-f194.google.com with SMTP id a26so3380544qtp.11 for ; Fri, 03 May 2019 01:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QyYnh8hGNxo4y79JyoBAvnyJOsqV/eKCHgC2055Dj70=; b=TFsaDfJktcepJhaSVkSy9jmcH5WklitGZ2BBIrKTkDmfye484EI32NBvqAF18RhDM4 icz2jBCDxSTj6qmQVp0LN0YlkJPVgxnXUunfIEesZ1FOAC5727DnzDgNJ++yI7ZM9nil K47/JWKZTYl0cyTlCD15zHWhm1WvSpjJECOdY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QyYnh8hGNxo4y79JyoBAvnyJOsqV/eKCHgC2055Dj70=; b=QBzj9/99avVfKtgQqQpqrtQeAf0mU4XUverxJcb343JgQw87q1vmaplo0B97186WRM lkNFMlkM8M8YE9M/63RXifsTC6NFtojPnZ6s9Ii+5HN8HvyO183mOE6loaG62nBBC8H+ WmTZDd6x1EBfCR1rqIEPHCJqv5I0kXZVJV7NuGdw9BxGi4qcs7kED1SWF06U45nuXaFw qtX3SWebFW3LK3LOJFQMLIU64olaG6UZFvn6kBkvD0AUrnBZ3KulKO2HpAF8UmWmfF1M 8KNzhj0KO0K1FeZh/ZwkMYo70Y10niqWj6r16FPLDweZpflozzvBtexo2vtIVGiizUEr KtRQ== X-Gm-Message-State: APjAAAWGueto4SP23lELRaaYjjIcM5w7z4D81QYM3Y++gYGisQInjz1l vro6SCmzAX8hK7Emz+Bai1WTjjRHQsVmeXKv9G8OAw== X-Received: by 2002:ac8:3822:: with SMTP id q31mr7331051qtb.0.1556870649914; Fri, 03 May 2019 01:04:09 -0700 (PDT) MIME-Version: 1.0 References: <1556793795-25204-1-git-send-email-michael.kao@mediatek.com> <1556793795-25204-2-git-send-email-michael.kao@mediatek.com> In-Reply-To: <1556793795-25204-2-git-send-email-michael.kao@mediatek.com> From: Hsin-Yi Wang Date: Fri, 3 May 2019 16:03:58 +0800 Message-ID: Subject: Re: [PATCH 1/8] arm64: dts: mt8183: add thermal zone node To: "michael.kao" Cc: fan.chen@mediatek.com, jamesjj.liao@mediatek.com, dawei.chien@mediatek.com, louis.yu@mediatek.com, roger.lu@mediatek.com, Zhang Rui , Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , Matthias Brugger , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 2, 2019 at 10:43 AM michael.kao wrote: > > Add thermal zone node to Mediatek MT8183 dts file. > > Signed-off-by: Michael Kao > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 64 ++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 926df75..b92116f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -334,6 +334,67 @@ > status = "disabled"; > }; > > + thermal: thermal@1100b000 { > + #thermal-sensor-cells = <1>; > + compatible = "mediatek,mt8183-thermal"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&infracfg CLK_INFRA_THERM>, > + <&infracfg CLK_INFRA_AUXADC>; > + clock-names = "therm", "auxadc"; > + resets = <&infracfg MT8183_INFRACFG_AO_THERM_SW_RST>; > + mediatek,auxadc = <&auxadc>; > + mediatek,apmixedsys = <&apmixedsys>; > + mediatek,hw-reset-temp = <117000>; > + nvmem-cells = <&thermal_calibration>; > + nvmem-cell-names = "calibration-data"; > + }; > + > + thermal-zones { > + cpu_thermal: cpu_thermal { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + > + thermal-sensors = <&thermal 0>; > + sustainable-power = <1500>; > + }; > + > + tzts1: tzts1 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 1>; Is sustainable-power required for tzts? Though it's an optional property, kernel would have warning: [ 0.631556] thermal thermal_zone1: power_allocator: sustainable_power will be estimated [ 0.639586] thermal thermal_zone2: power_allocator: sustainable_power will be estimated [ 0.647611] thermal thermal_zone3: power_allocator: sustainable_power will be estimated [ 0.655635] thermal thermal_zone4: power_allocator: sustainable_power will be estimated [ 0.663658] thermal thermal_zone5: power_allocator: sustainable_power will be estimated if no sustainable-power assigned. > + }; > + > + tzts2: tzts2 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 2>; > + }; > + > + tzts3: tzts3 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 3>; > + }; > + > + tzts4: tzts4 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 4>; > + }; > + > + tzts5: tzts5 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 5>; > + }; > + > + tztsABB: tztsABB { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 6>; > + }; > + }; > audiosys: syscon@11220000 { > compatible = "mediatek,mt8183-audiosys", "syscon"; > reg = <0 0x11220000 0 0x1000>; > @@ -368,6 +429,9 @@ > compatible = "mediatek,mt8183-efuse", > "mediatek,efuse"; > reg = <0 0x11f10000 0 0x1000>; > + thermal_calibration: calib@180 { > + reg = <0x180 0xc>; > + }; > }; > > mfgcfg: syscon@13000000 {