Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp273641yba; Fri, 3 May 2019 01:20:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8ksD8L+qncWrsBwsY4D5PTM783282HHcI/iOm0BSFOG2XnQ/F5XMRjD+VmqaE0Uh8TfL8 X-Received: by 2002:a62:2b4e:: with SMTP id r75mr9008903pfr.131.1556871651122; Fri, 03 May 2019 01:20:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556871651; cv=none; d=google.com; s=arc-20160816; b=lnKtF4b+2DRd63Mbyl5tvF+/jSs46KyPZHxBmCKKX5Vn3MtoxTwhYsNqfB/romp+GM hO3hg4hkiJQBSH87lFeui4of0XYnSxvEyPJuVO5SfbFY1nCXgzrkZJpivZ/VZlDcug/N gdvy43BEfTpVasw8mvJ6FFZ3+vZFVhaRGjUCxjK/dY/cDVBuHG0C4cCqwNoUg7kN6hlc 9ktuZuE0J3MBwzyFTOQEEw3d/U/z/X+5bHOczp4yY1rI1lzpTWpLfJXs94pcsgicKwU5 iLXil+VYU3/9caHF0jo5AAANcEupvKPyRRfcpgDNOUJeGAYodM1Blv2mox1Q0t4Kq3D3 2Kvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EsrQrWQfLeM6pAIWGW+Uvo4NkIA8xqL9RFC+iSfMFJM=; b=OidhIcUiPt3KSMhotGX5xxVOoYYM9dqDnd744NCy5l20w3tkehPquH+bpzYgRxBn2+ cFkUf3w/tyNoSujWniLI6a1Be5f1WZg3fM5id9jCTERxxiRkONn6m2VKWhDZtVaiMfOv RupqcUO4HztO0XT8Xp/iSiTEyl+ZmYMPnLltwUiHm9R8ynuIrqWgm5oECstijlmJUlEk v173uZkL9zv1iQG5oHLJVeqhDIYUyHfz10BCrxgD4IaueNfHS08Ccp+7UiB5AvoH4Xj1 gN9Mv6b0vHRGl05WM8eXcfxgl1YqaNHNUwoFBrvxv6yMNx8KAZdzVGGXJsSZIeKWLSP8 dUGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f7si1511467plo.204.2019.05.03.01.20.35; Fri, 03 May 2019 01:20:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726546AbfECINI (ORCPT + 99 others); Fri, 3 May 2019 04:13:08 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57343 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfECINI (ORCPT ); Fri, 3 May 2019 04:13:08 -0400 X-Originating-IP: 90.88.149.145 Received: from localhost.localdomain (aaubervilliers-681-1-29-145.w90-88.abo.wanadoo.fr [90.88.149.145]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id E4CB220007; Fri, 3 May 2019 08:13:04 +0000 (UTC) From: Paul Kocialkowski To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Eric Anholt , David Airlie , Daniel Vetter , Maxime Ripard , Eben Upton , Thomas Petazzoni , Paul Kocialkowski Subject: [PATCH v8 0/4] drm/vc4: Binner BO management improvements Date: Fri, 3 May 2019 10:12:38 +0200 Message-Id: <20190503081242.29039-1-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes since v7: * Moved the used bool to vc4_v3d_bin_bo_get in order to check it locked and avoid a possible race condition; Changes since v6: * Removed vc4_v3d_bin_bo_put from error paths; * Added WARN_ON_ONCE when no bin BO at refcount release. Changes since v5: * Fix more locking mistakes; * Introduce get/put helpers; * Grabbed a reference when submitting an exec job with a binner slot. * Addressed misc comments. Changes since v4: * Used a kref on the binner bo instead of firstopen/lastclose; * Added a mutex to prevent race conditions; * Took care of enabling the OOM interrupt when we have a binner BO allocated. Changes since v3: * Split changes into more commits when possible; * Reworked binner bo alloc condition as discussed. Changes since v2: * Removed deprecated sentence about fristopen; * Added collected Reviewed-By tags. Changes since v1: * Squashed the two final patches into one. Paul Kocialkowski (4): drm/vc4: Reformat and the binner bo allocation helper drm/vc4: Check for V3D before binner bo alloc drm/vc4: Check for the binner bo before handling OOM interrupt drm/vc4: Allocate binner bo when starting to use the V3D drivers/gpu/drm/vc4/vc4_bo.c | 31 ++++++++++++++- drivers/gpu/drm/vc4/vc4_drv.c | 6 +++ drivers/gpu/drm/vc4/vc4_drv.h | 14 +++++++ drivers/gpu/drm/vc4/vc4_gem.c | 11 ++++++ drivers/gpu/drm/vc4/vc4_irq.c | 20 ++++++++-- drivers/gpu/drm/vc4/vc4_v3d.c | 74 +++++++++++++++++++++++++++-------- 6 files changed, 134 insertions(+), 22 deletions(-) -- 2.21.0