Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp333084yba; Fri, 3 May 2019 02:46:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqySCjlc7ikDkebrjF8sClseo3W5SLeE3kc4CKvzTTjz6zOJRdDGvZ57TkaTgo64gx83pOa1 X-Received: by 2002:a65:534b:: with SMTP id w11mr9071958pgr.210.1556876778686; Fri, 03 May 2019 02:46:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556876778; cv=none; d=google.com; s=arc-20160816; b=Qbcs/huDAROAeOFZd7JK6+q8Jhh9k/fuWShHi5+HffVHnIVuHuuJBvqqRoZz5oPC1Z 5JPloyZ/0pyPlpBlt7/Rl8LTBwhS2Y9+j8p1Iw8Ov7SEmfzXLWxlpavESwWTu5d+n0OE sLnWhs6xo6JC1tFBYcuAgtSEMG+E3Beh/OVoIl64wVovCSPkj1REeo3pVYul2bNJCNHp EdW2Cp4C6xej1vH8ogMbR6j/w2I8LmqheXHsBJ/eUJFPdjHsuNNZ2MAxUH2UaDYs9Dxe mk+Lx3hHslwDQab7ERkqx6Vy5VbQiyvnvrRv/CUy/pBq2j2WHcMVECMzq+ePyL/956gM 3Bng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=BXzCye4OqYPlszn70+k37eGTOKA1sIhwyx2ch7xS6SI=; b=S8Y8XkK5pAJoMVLYkvurSpNjBV7f+UKKJaLxktUAxATADl1vouttQ5ZLRj3/LKSFXn 6G8qP9zJlNAWA9m0iGt4ap6F0k8g3iDd0tbT6ZMY1XdgX0RPSN0Wi06E/MaTkFEBbBrV QJTbH69GRru0qTw8OVfyNh4X/hjlDWTnmwg1lGJQSmgu6v8eLQHeq9Vo8+7LQxvmRnx2 W+ulzoDbC9xs2EeTF6kF1a1y+kwcvgf7pAEhoqSVi4p095ZBPqLomr7BOt8CTzDrLqsb 7dlF7jYksj8sSb7zJQF6klDhgbueLWbRp9q2S+pO94zwDsPrfGvN5XCPnB1UIjfXVp3i cCBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i8si1535957pgq.468.2019.05.03.02.46.03; Fri, 03 May 2019 02:46:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727060AbfECJju (ORCPT + 99 others); Fri, 3 May 2019 05:39:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:45480 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726047AbfECJju (ORCPT ); Fri, 3 May 2019 05:39:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E318AAEDB; Fri, 3 May 2019 09:39:48 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 618E8DA885; Fri, 3 May 2019 11:40:48 +0200 (CEST) Date: Fri, 3 May 2019 11:40:48 +0200 From: David Sterba To: Kimberly Brown Cc: Chris Mason , Josef Bacik , David Sterba , Greg Kroah-Hartman , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: sysfs: Replace default_attrs in ktypes with groups Message-ID: <20190503094047.GE20156@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Kimberly Brown , Chris Mason , Josef Bacik , David Sterba , Greg Kroah-Hartman , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190502173445.5308-1-kimbrownkd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502173445.5308-1-kimbrownkd@gmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 01:34:45PM -0400, Kimberly Brown wrote: > The kobj_type default_attrs field is being replaced by the > default_groups field. Replace the default_attrs fields in > btrfs_raid_ktype and space_info_ktype with default_groups. > > Change "raid_attributes" to "raid_attrs", and use the ATTRIBUTE_GROUPS > macro to create raid_groups and space_info_groups. > > Signed-off-by: Kimberly Brown Acked-by: David Sterba > --- > > This patch depends on a patch in the driver-core tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=aa30f47cf666111f6bbfd15f290a27e8a7b9d854 > > GregKH can take this patch through the driver-core tree, or this patch > can wait a release cycle and go through the subsystem's tree, whichever > the subsystem maintainer is more comfortable with. Please take it through the driver-core tree, thanks.