Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp492627yba; Fri, 3 May 2019 05:51:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTBRuLqR+IS2fLUBPc6d0LGkoxciV8K2nNyr2F8tnhO0o+ORswB+AM9E4rYYEcpY4JIO7+ X-Received: by 2002:a62:1d94:: with SMTP id d142mr10511895pfd.83.1556887876115; Fri, 03 May 2019 05:51:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556887876; cv=none; d=google.com; s=arc-20160816; b=PJPyy60+t95psFzjKpkvwof11WucltvFS4zsp8hpdBsnodjaIcHuoY6JJRUOvQ2ATT 9NxaronSKYoP2qh9+kJaiMcxTWtjj5YpNHTrjHzTExAL9p6TUW8AVMOv9WtFGFX2YHUS VhZ60ueJxpy8vlIPoLk6df0X3jKoJI4TANH2WAH4eNiwmkHQFO5OtsOpWMB2HYIFrlza A84G1ueXJTQqB8kEMo6HOdd+xjpVJ4IJpV3e1N7u5O6BZW41lLk0bPyYZanJtIRLvUSh S7V8xktsWDp5aZ269QONdFOym7rtSMw6QCRAJH3MkNRu+tuwp4SBijt+pNVQO2fHZi4L iInw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=wXXVYe18skM+2Lbt8ApQj++Nl03yrujCawSzJnFQQ74=; b=k9bAZfojMCGV0BG/0oTA7Yge4ZJQfJnd0XoYBrmB9Y2nYpLjfQe9JMSfuKHHaLlHIW hIiqNBb5iByrbzzW7YrVARNc2XDDEOqH9L6zhsWae5VhYLLK+TmNey7fFKiv48fmnWJq 9ouLWQyq06c2bp7jmhRWQ5xDfTieG+uFg2fQgdzosmIesEsmZUeC091O8VQXVMAjWU6R R3prTBLoPlCyDPZw8QGXGgwC2s7daY7nbxtJ3u56nJAhGYnae7BTNfZGrH93e5vzZYsG 6FXToDSngzoaQH2w4z97537KelvQnRxIEs46ohAPSg6lMDlt/WgKsVT+quUEPdMKffLz k2LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UdkY7xlw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j127si2184400pfb.25.2019.05.03.05.51.00; Fri, 03 May 2019 05:51:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UdkY7xlw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727925AbfECMmW (ORCPT + 99 others); Fri, 3 May 2019 08:42:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:45362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727032AbfECMmW (ORCPT ); Fri, 3 May 2019 08:42:22 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A9E22075E; Fri, 3 May 2019 12:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556887341; bh=82WGJLwfu51418WgW0AMMuUlO3hHLGELfWELisFxIxw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=UdkY7xlws5JZVWfKukbn+3hW5DuBkAZEvlsnuiKzpgIUkWY3m56S7kLQQ0p2GNrw3 iifrXECZLeAcnyXXLJOUiptlqAUyPR0x6wxpfUCspkoZnrk4eERExuvkFnnuvxZFCT lKczVouw6DS6yuSwWMifO6vnKtasIJ2Fjfpwe1iQ= Date: Fri, 3 May 2019 14:42:18 +0200 (CEST) From: Jiri Kosina To: Fabien DESSENNE cc: Benjamin Tissoires , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter In-Reply-To: <9628edde-5270-d5a5-7db6-c9ec3f47c742@st.com> Message-ID: References: <1555073657-24386-1-git-send-email-fabien.dessenne@st.com> <9628edde-5270-d5a5-7db6-c9ec3f47c742@st.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 May 2019, Fabien DESSENNE wrote: > >> - ret = devm_add_action_or_reset(&hdev->dev, &rmi_irq_teardown, hdata); > >> + ret = devm_add_action_or_reset(&hdev->dev, rmi_irq_teardown, hdata); > > Why do you think this is wrong C? > > Because I was not aware that both func and &func refer to the same > function pointer. > > Now I know :) Yup, it's defined in 6.3.2.1.4 in C99. -- Jiri Kosina SUSE Labs