Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp568654yba; Fri, 3 May 2019 07:03:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOrTDDOJitPQuhUkvaTRC0LTl3Eu7GGdKnT+wK8UQNORfDzGZA7NGExQOB48MTgAAlXYyf X-Received: by 2002:a17:902:820c:: with SMTP id x12mr10149465pln.199.1556892183492; Fri, 03 May 2019 07:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556892183; cv=none; d=google.com; s=arc-20160816; b=CDDh0r8PZ6qCPsxZHywzWF4LONYMRsJtx5aVDF1oKwh7KXsc+SW1DdpIRXiGltG/wt ortAXigQOgcGIeslfu3ZCelvWi4d9WB66YbttacvVlq3kAiT6L5/KY1ceb7Xk+kOMZ/x dHepGUKsBIdIODy1xhjx14BmzH0RO/5lc6c3McwGlEacjPbUX1DShUfig3app7OTUoS8 fW51t2SmNlHyQ9ZRFDvxJPWb/hA96RqIYDoIVtA8fSEhq35uptMlFlpoKQ1p7m6nYnwG W8SVizhSjMO3Ard8h/IFssLukp1dSvYECfGGxBVHK7wxlL+23IRGabX0WgFOo5qOW1/c kWIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=9u42czGXur/Adt7VdExZGvcfuDUmoewnxEXNTyURWvQ=; b=OkFDVzlsxW4T7rHR508Xh5eG1Ed7JkTA6AWydclV8y8IfrePlLXbW4jUZyqWgxByWB 71BHbIceM9+9VvttI99/L8LOUncafnbCVaWVwxlANkYMAPMogTcuRSH8h+JTSe86jDkz b3Kuj4sRQag6AAPaS7OiXILrAclAH+Gk+kETNKA8CsAz2uxLEBPyw/aP3mvHpZidXBsA DrGU922TFMA0UPXpNUzaMpk77CFslE3VdgXGaiYQUeUl1K+HO9ki60GO/bDtGDoccHAu 5016ckhcUQD4sJOvlLe8xYjrfZmB0QBqmmIB+pFuMDyFN9VrOXdgQ3YoEnm/GgXnEUAv Wq0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a39si2788125pla.0.2019.05.03.07.02.43; Fri, 03 May 2019 07:03:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728035AbfECN5l (ORCPT + 99 others); Fri, 3 May 2019 09:57:41 -0400 Received: from mxout014.mail.hostpoint.ch ([217.26.49.174]:12691 "EHLO mxout014.mail.hostpoint.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbfECN5l (ORCPT ); Fri, 3 May 2019 09:57:41 -0400 Received: from [10.0.2.46] (helo=asmtp013.mail.hostpoint.ch) by mxout014.mail.hostpoint.ch with esmtp (Exim 4.91 (FreeBSD)) (envelope-from ) id 1hMYgy-000329-Ma; Fri, 03 May 2019 15:57:36 +0200 Received: from [46.140.72.82] (helo=philippe-pc.toradex.int) by asmtp013.mail.hostpoint.ch with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91 (FreeBSD)) (envelope-from ) id 1hMYgy-0003ks-De; Fri, 03 May 2019 15:57:36 +0200 X-Authenticated-Sender-Id: dev@pschenker.ch From: Philippe Schenker To: linux-iio@vger.kernel.org, Jonathan Cameron , Stefan Agner , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: dev@pschenker.ch, Philippe Schenker , Max Krummenacher , Alexandre Torgue , linux-kernel@vger.kernel.org, Lee Jones , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] iio: stmpe-adc: Remove unnecessary assignment Date: Fri, 3 May 2019 15:57:23 +0200 Message-Id: <20190503135725.9959-1-dev@pschenker.ch> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philippe Schenker Remove unnecessary assignment. This could potentially cause an issue, if the wait function runs into a timeout. Furthermore is this assignment also not there in stmpe_read_temp() Signed-off-by: Philippe Schenker --- drivers/iio/adc/stmpe-adc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c index 37f4b74a5d32..87141177fbda 100644 --- a/drivers/iio/adc/stmpe-adc.c +++ b/drivers/iio/adc/stmpe-adc.c @@ -78,8 +78,6 @@ static int stmpe_read_voltage(struct stmpe_adc *info, stmpe_reg_write(info->stmpe, STMPE_REG_ADC_CAPT, STMPE_ADC_CH(info->channel)); - *val = info->value; - ret = wait_for_completion_interruptible_timeout (&info->completion, STMPE_ADC_TIMEOUT); -- 2.21.0