Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp607937yba; Fri, 3 May 2019 07:37:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUdBIpIxPPj2DfsJRnGjQ3roFur5KxLQAYBVWVmrdTm1EacnhJzn1RxF8Q4dvr8q+njQC9 X-Received: by 2002:aa7:8e55:: with SMTP id d21mr11166188pfr.62.1556894272922; Fri, 03 May 2019 07:37:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556894272; cv=none; d=google.com; s=arc-20160816; b=OQqOSNAFXr1kDz6IyjMA7eA5B7YVbAbx0ayuYNb6fUSGuVD/qWLWJ5qkD8IKs5GsCW A4/hLkBoZdGFOL1BHtU1pGPJ4FHvXv2nf3n6ZCdeRwhuAML54XTVA7xvA6CK8+9wPMf8 SnaOdGbeIyVzg2AFGh1oBW6vTeBTeIqiyOnrSIa/qVJqxGJPgy8KVEOBsLRnh1VlQCeR 6pZRmXgimZl+lRE6nMxgksiCBdKSqieLXKefZSDCEj45x58aByaQQ5aOAZE41rEeSwG+ y3aWOpHxBhfxu7kmIB9RuwiQoV8OFmVFOZjIamNrnthDzJtdLzcHqrtm7gTdFUt6sXyV muSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=a2SZICWq+Y+RA7TOEOA3JUllOybUanzgXoJemq2MGPg=; b=LLSQSURpfKLeOOzVXqD6i512d0nikRSHtUGeJvAU/WCx72eb4SRmoeDWmPt+2tUDTV 3MbTeA7xE2hLOllb0su+Fsb+39EDSLbxtpSOjtT5GZkQMirDNCCyBjGUzjVLoP4WrF5o paTorZNUVvSL2aXNmmbxGc30A5TGAx57BMCTjHNhrKSPzJ/ASYjCs+FL4fsKST91q2yi KLMmWcVlXCkG0bcvgE55Lohht/Ri19Pdcg3WajfIHlBEqBtuKUPyrdypEGdKMT+M5dRn Ro0FGKTOq6Dgd/VFlBGQT6jp6IBBw+ELSw/GRiH/yjozTOVWqPHVyf3GUWKreAwJDhQO bYjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si656185pln.239.2019.05.03.07.37.37; Fri, 03 May 2019 07:37:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728270AbfECOfn (ORCPT + 99 others); Fri, 3 May 2019 10:35:43 -0400 Received: from smtp-out.xnet.cz ([178.217.244.18]:17190 "EHLO smtp-out.xnet.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728171AbfECOfT (ORCPT ); Fri, 3 May 2019 10:35:19 -0400 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id EA69D4AD5; Fri, 3 May 2019 16:27:47 +0200 (CEST) Received: by meh.true.cz (OpenSMTPD) with ESMTP id 27d916b3; Fri, 3 May 2019 16:27:47 +0200 (CEST) From: =?UTF-8?q?Petr=20=C5=A0tetiar?= To: netdev@vger.kernel.org, devicetree@vger.kernel.org, Greg Kroah-Hartman Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , =?UTF-8?q?Petr=20=C5=A0tetiar?= , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 08/10] staging: octeon-ethernet: support of_get_mac_address new ERR_PTR error Date: Fri, 3 May 2019 16:27:13 +0200 Message-Id: <1556893635-18549-9-git-send-email-ynezz@true.cz> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1556893635-18549-1-git-send-email-ynezz@true.cz> References: <1556893635-18549-1-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There was NVMEM support added to of_get_mac_address, so it could now return ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. Signed-off-by: Petr Štetiar --- Changes since v3: * IS_ERR_OR_NULL -> IS_ERR drivers/staging/octeon/ethernet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index 986db76..2b03018 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -421,7 +421,7 @@ int cvm_oct_common_init(struct net_device *dev) if (priv->of_node) mac = of_get_mac_address(priv->of_node); - if (mac) + if (!IS_ERR(mac)) ether_addr_copy(dev->dev_addr, mac); else eth_hw_addr_random(dev); -- 1.9.1